Read path to new likelihood file from parameter file

A new reference file for the likelihood calculation was added to the parameter repository (see commit). With these commits, the path to the likelihood file is not hard coded in the CbmTrdGas class anymore, but is read directly from the parameter file trd_vXX_XX.gas.par via the CbmTrdParSetGas and CbmTrdParModGas classes. Since the CbmTrdParModGas is also used for the creation of said paramater files, it is initialized with new default path to the reference file. When creating parameter files, this path will be written into the parameter file. In analysis this path will be overwritten by the path from the parameter file.

EDIT: Pipelines were failing on macosx 11 and macosx 1015, while passing on all other systems.

When looking into the output of the failed tests from the pipelines in cdash, it was noticed that on these systems, a whitespace was added somehow to the end of the likelihood file name when it was to be opened in the CbmTrdSetTracksPidLike.cxx. Therefore the file could not be opened resulting in a fatal error.

I do not know why this happens on certain mac versions and not on others. To circumvent this issue, any additional characters will be chopped off from the file name before it is read in the CbmTrdSetTracksPidLike.cxx as follows (see commit):

    //Whitespace added on some mac versions somehow to the filename resulting in fatal error, chop away here
    while (!fFileName.EndsWith(".root"))
      fFileName.Chop();

Since the file is only opened once at the start of the analysis, this does not impact the performance.

changed title from Newtrdlikeref to Read path to new likelihood file from parameter file

added 1 commit

• 0a35eb8f - Apply Clang format

Compare with previous version

added 6 commits

• 0a35eb8f...4b6042e1 - 2 commits from branch computing:master
• 1e418270 - path to likelihood file is read from parameter file instead of being hard coded
• 8af96313 - Get path of likelihood reference from parameter file instead of CbmTrdGas class
• a0299bd1 - Initialize CbmTrdParModGas with default PID file name. Needed for parameter generation
• a8783bb4 - Apply Clang format

Compare with previous version

added 120 commits

• a8783bb4...fe19f13e - 116 commits from branch computing:master
• ba843700 - path to likelihood file is read from parameter file instead of being hard coded
• 8b00faff - Get path of likelihood reference from parameter file instead of CbmTrdGas class
• 3c449c03 - Initialize CbmTrdParModGas with default PID file name. Needed for parameter generation
• 03ac7b0a - Apply Clang format

Compare with previous version

added 1 commit

• e0663076 - Try to fix error on some mac versions by not re-initializing string

Compare with previous version

added 10 commits

• e0663076...d3668f78 - 5 commits from branch computing:master
• bf958f0c - path to likelihood file is read from parameter file instead of being hard coded
• 894361e1 - Get path of likelihood reference from parameter file instead of CbmTrdGas class
• 232e07bb - Initialize CbmTrdParModGas with default PID file name. Needed for parameter generation
• 7f3a8bf3 - Apply Clang format
• cb232fae - Try to fix error on some mac versions by not re-initializing string

Compare with previous version

added 2 commits

• fbfcf9ac - Revert last commit, since it did not fix the error
• fda15d71 - Fix added whitespace on mac by chopping

Compare with previous version

Dear @a.bercuci, @p.kaehler,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

assigned to @se.gorbunov

@a_meye37_AT_uni-muenster.de,

do you need a review from TRD people, or should I already merge your MR?

@se.gorbunov thanks for asking, I would wait for some comments from the other TRD people, we will discuss this on Wednesday in the TRD meeting.

Many thanks for preparing. Recommend to ask @a.bercuci for a review.

changed the description

added 8 commits

• 07a32204 - 1 commit from branch computing:master
• 6f51a788 - path to likelihood file is read from parameter file instead of being hard coded
• 014a6df2 - Get path of likelihood reference from parameter file instead of CbmTrdGas class
• 14e829e1 - Initialize CbmTrdParModGas with default PID file name. Needed for parameter generation
• f04aef88 - Apply Clang format
• 1112dbf2 - Try to fix error on some mac versions by not re-initializing string
• 2c715286 - Revert last commit, since it did not fix the error
• cadd2881 - Fix added whitespace on mac by chopping

Compare with previous version

@se.gorbunov @f.uhlig since the last rebase the job CbmRoot_Merge_Singularity_centos7_apr21 fails due to a timeout of the load_libraries test:

161/161 Test  #28: load_libraries ....................................***Timeout 600.00 sec
        Start  28: load_libraries
      Test  #28: load_libraries ....................................***Timeout 600.01 sec

Before the rebase, the test succeeded in 523 seconds.

161/161 Test  #28: load_libraries ....................................   Passed  523.19 sec

It seems the merge request 909 has the same issue. Do you have any idea why the script is taking longer now? Thanks!

added 16 commits

• cadd2881...1ce81b17 - 9 commits from branch computing:master
• e8c3c30f - path to likelihood file is read from parameter file instead of being hard coded
• 5cd28131 - Get path of likelihood reference from parameter file instead of CbmTrdGas class
• 39038b44 - Initialize CbmTrdParModGas with default PID file name. Needed for parameter generation
• ee2e69f1 - Apply Clang format
• a6a35916 - Try to fix error on some mac versions by not re-initializing string
• 88f5790c - Revert last commit, since it did not fix the error
• a0ac9a30 - Fix added whitespace on mac by chopping

Compare with previous version

resolved all threads

added 18 commits

• a0ac9a30...f8d705a5 - 11 commits from branch computing:master
• f6fd9c39 - path to likelihood file is read from parameter file instead of being hard coded
• df625a92 - Get path of likelihood reference from parameter file instead of CbmTrdGas class
• 6db7e83e - Initialize CbmTrdParModGas with default PID file name. Needed for parameter generation
• fb579312 - Apply Clang format
• 8735fa65 - Try to fix error on some mac versions by not re-initializing string
• 9b6ab32f - Revert last commit, since it did not fix the error
• 43810837 - Fix added whitespace on mac by chopping

Compare with previous version