Bugfix material budget Sts macro

Previously radiation thickness of materials that transversed a cut boundary were ignored, leading to an underestimation of radiation length.

Allows non equidistant station cuts, such as is needed for the new 5+3 station STS geometries.

Review requested from @m.shiroya

added 1 commit

• c067a1a9 - Bugfix material budget Sts macro

Compare with previous version

Percentage of the total material budget added across full sts by including volumes that tranverse multiple station cuts. Ignore title.

@e.clerkin

I used the macro that you sent to git as a merge request.

I checked the geometry v21e with the following pointsIn in each stations, These are the starting point of the boundaries and end points of the boundaries for the STS BOX and Sts stations.

double boundaries[nStations + 3] = { -42.4, -20.00, -9.50, 1.0, 11.5, 22.0, 32.5, 43.0, 53.5, 65.50, 79.5};

I have considered the exact boundary position from where actual C-frames start for each STS station.

Previously, it was:

Hi @m.shiroya,

Do I understand correctly, that the material budget plots you display have exactly the same cut boundaries (z positions) using the old (below) and new (above) calculation methods? Or are they still different?

In stations 7 and 8, the red header and footer in the upper plots which is absent in the lower plots, does this material which leads to this radiation thick region transverse the cut boundary, i.e. z = 53.5 and 65.5 centimeters?

Many thanks, Eoin

Dear Eoin,

Yes, in the few stations the cut boundries looks similar using New and the Old calculation methods. But, in the older method only few station/s seems to have a different boundries compared to the new calculation method.

I think new method of the calculation which you have implemented makes more sense to adapt for the future geometries.

Thank you.

With best regards, Mehul

added 1 commit

• e2e77f3f - Bugfix material budget Sts macro

Compare with previous version

@e.clerkin],

The code format check failed. You may need to install the proper version of clang-format: https://redmine.cbm.gsi.de/projects/cbmroot/wiki/Clang-format

added 242 commits

• e2e77f3f...d7f0b0f4 - 241 commits from branch computing:master
• 47b83206 - Bugfix material budget Sts macro

Compare with previous version

resolved all threads

approved this merge request

@p.-a.loizeau considering mcbm discussions today, this should be merged.

Dear @v.friese,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

assigned to @se.gorbunov

requested review from @se.gorbunov

Assigning to Serguey as he is the last I know to have touched the material budget macros. And he should also know whom in the tracking side to work with

added 7 commits

• 47b83206...0c236493 - 6 commits from branch computing:master
• dc8b39ca - Bugfix material budget Sts macro

Compare with previous version

merged