Revised CbmDevEventSink. Remove histogramming and timeslice buffering.
This is a revision of CbmDevEventSink, substantially thinning the code and stripping down to the basic functionality:
- Remove histogram handling. The device does not actually fill any histograms, nor does it run an algorithm.
- Remove timeslice buffering and creation of dummy timeslice data. Previously, timeslice data (metadata and event array) were buffered if timeslices do not arrive in sequential index order. This is a questionable concept, since a. it relies on missing timeslices being reported through a different channel (if not, there will be no output in the file after the first gap), and b. real timeslices will be large (several GB), and will be so also after event building (if not a very selective trigger is applied).
In addition, some code cleanup was applied.
Merge request reports
Activity
requested review from @d.smith
assigned to @p.-a.loizeau
Dear @f.uhlig, @v.friese, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
- Resolved by Pierre-Alain Loizeau
@v.friese I reviewed the code and it looks good to me. I was also able to run it on my machine, and it produced sensible output.
Regarding histogram production and "missed timeslice" handling: There are probably some requirements from the beam time crew concerning both of these topics, but this should be discussed/addressed elsewhere (with @p.-a.loizeau and others). The present MR seems to offer the minimal working example.
added 4 commits
-
63e7b9bb...19ab4b46 - 3 commits from branch
computing:master
- 6b34bd16 - Revised CbmDevEventSink. Remove histogramming and timeslice buffering.
-
63e7b9bb...19ab4b46 - 3 commits from branch
@p.-a.loizeau Can you merge this? I would like to base my next work on this.
added 5 commits
-
6b34bd16...803ed31c - 4 commits from branch
computing:master
- 26080ec4 - Revised CbmDevEventSink. Remove histogramming and timeslice buffering.
-
6b34bd16...803ed31c - 4 commits from branch
enabled an automatic merge when the pipeline for 26080ec4 succeeds