L1: Interfaces updates

NOTE: If your reconstruction macro throws fatal error after this merge, please, add the following task before CbmKF: run->AddTask(new CbmTrackingDetectorInterfaceInit());

• Geometry parameters of L1Algo were incapsulated inside the L1Parameters, compile-time constants were moved to L1Constants.h
• Tracking interfaces for MVD, STS, MuCh and TRD were introduced:
  • CbmMvdTrackingInterface,
  • CbmStsTrackingInterface,
  • CbmMuchTrackingInterface,
  • CbmTrdTrackingInterface
• Consistency checks for L1Algo parameter structures were added

added CodeOwners Reconstruction labels

requested review from @v.akishina

assigned to @se.gorbunov

changed the description

added 13 commits

• 50cf5653...48b266f3 - 2 commits from branch computing:master
• a351970a - CbmTrackerInterface is introduced for STS and MVD
• 62848683 - Renamed TrackerIF classes
• a2111998 - L1Algo: constexpr constants moved from L1Parameters class to the L1Constants...
• ed56bac6 - L1: Changed L1Algo initialization logic, moved geometry parameters to L1Parameters
• a01e461d - L1: add consistency checkers for L1Parameters, L1Station, L1UMeasurementInfo,...
• d89723d2 - L1: CbmMuchTrackerIF added
• bdb6e0b3 - L1: tracking interface moved to KF.lib (tmp), TRD interface was added
• 04346c42 - L1: renamed tracking interface classes + clang format bugfix
• 1940ab47 - L1: tracking interfaces: the interface classes were moved to the...
• 1a04413d - reconstruction macros global updates: CbmL1 and CbmKF (as a FairRoot task) now...
• 3fce9ff0 - reconstruction macros global updates (bugfix): CbmL1 and CbmKF (as a FairRoot...

Compare with previous version

added 12 commits

• c03fa315 - CbmTrackerInterface is introduced for STS and MVD
• e3b2094f - Renamed TrackerIF classes
• 569da270 - L1Algo: constexpr constants moved from L1Parameters class to the L1Constants...
• 35c470d3 - L1: Changed L1Algo initialization logic, moved geometry parameters to L1Parameters
• eaf2f358 - L1: add consistency checkers for L1Parameters, L1Station, L1UMeasurementInfo,...
• 8c3156af - L1: CbmMuchTrackerIF added
• 14cc9dde - L1: tracking interface moved to KF.lib (tmp), TRD interface was added
• 0c021ea5 - L1: renamed tracking interface classes + clang format bugfix
• f69a6eae - L1: tracking interfaces: the interface classes were moved to the...
• 6b59aee7 - reconstruction macros global updates: CbmL1 and CbmKF (as a FairRoot task) now...
• 50cf5653 - reconstruction macros global updates (bugfix): CbmL1 and CbmKF (as a FairRoot...
• 8c25c74b - code-format + license fix

Compare with previous version

added 14 commits

• 8c25c74b...48b266f3 - 2 commits from branch computing:master
• 79a8b343 - CbmTrackerInterface is introduced for STS and MVD
• 6eba20d5 - Renamed TrackerIF classes
• 18fdbc90 - L1Algo: constexpr constants moved from L1Parameters class to the L1Constants...
• a91ff5c1 - L1: Changed L1Algo initialization logic, moved geometry parameters to L1Parameters
• 018b2d30 - L1: add consistency checkers for L1Parameters, L1Station, L1UMeasurementInfo,...
• 5b1b0165 - L1: CbmMuchTrackerIF added
• f2a46f58 - L1: tracking interface moved to KF.lib (tmp), TRD interface was added
• f6287b39 - L1: renamed tracking interface classes + clang format bugfix
• 80271fb9 - L1: tracking interfaces: the interface classes were moved to the...
• f9fd740a - reconstruction macros global updates: CbmL1 and CbmKF (as a FairRoot task) now...
• af9ffb65 - reconstruction macros global updates (bugfix): CbmL1 and CbmKF (as a FairRoot...
• e4abba4c - code-format + license fix

Compare with previous version

added 1 commit

• a3d8b5c8 - macro/much/run_ana.C: added MuCh digi parameters initialization

Compare with previous version

added 1 commit

• de304f90 - code-format fix

Compare with previous version

added 1 commit

• 3d4e784b - added CbmTrackingDetectorInterfaceBase.h to HEADERS

Compare with previous version

@s.zharko,

please find attached the needed patch to install the file. In my test this was enough to fix the installation test.

diff --git a/core/base/CMakeLists.txt b/core/base/CMakeLists.txt
index ee65ab3b..822f3d9a 100644
--- a/core/base/CMakeLists.txt
+++ b/core/base/CMakeLists.txt
@@ -69,6 +69,6 @@ Set(DEPENDENCIES
 
 GENERATE_LIBRARY()
 
-Install(FILES CbmDigitize.h report/CbmReportElement.h
+Install(FILES CbmDigitize.h CbmTrackingDetectorInterfaceBase.h report/CbmReportElement.h
         DESTINATION include
        )

added 1 commit

• e7134595 - /core/base/CMakeLists.txt patch

Compare with previous version

@s.zharko,

you also have to fix the build system of the KF package. Otherwise the linker on macosx12 isn't happy. Obviously you use some function from two libraries which you don't link

diff --git a/reco/KF/KF.cmake b/reco/KF/KF.cmake
index 083663bc..6a816dba 100644
--- a/reco/KF/KF.cmake
+++ b/reco/KF/KF.cmake
@@ -174,7 +174,7 @@ ENDIF (SSE_FOUND)
 set(LINKDEF KFLinkDef.h)
 Set(LIBRARY_NAME KF)
 Set(DEPENDENCIES
-  CbmStsBase CbmMvd CbmBase CbmRecoBase CbmMuchBase CbmData Base Vc.a Minuit2
+  CbmRecoBase CbmSimSteer CbmStsBase CbmMvd CbmMuchBase CbmTrdBase CbmBase CbmData Base Vc.a Minuit2
 )
 Set(DEFINITIONS -DDO_TPCCATRACKER_EFF_PERFORMANCE -DNonhomogeneousField -DCBM -DUSE_TIMERS)

added 1 commit

• 9c7c34c7 - reco/KF/KF.cmake: added dependency on CbmTrdBase lib (bugfix)

Compare with previous version

@s.zharko,

I canceled the pipeline since you missed to add CbmSimSteer.

added 2 commits

• 0418b5e1 - reco/KF/KF.cmake: added dependency on CbmTrdBase lib (bugfix)
• f17161eb - reco/KF/KF.cmake: added dependency on CbmTrdBase, CbmSimSteer lib (bugfix)

Compare with previous version

approved this merge request

resolved all threads

merged