Add GPU Hitfinder to STS local reconstruction.
Good things come to those who wait...
This MR introduces an alternative implementation of the STS reconstruction that is runnable on GPU. It's possible to switch between both implementation via a new flag in the run_reco.C
macro.
There are however still a number of limitations / issues:
- Digis for sts clusters are not collected.
- Implementation is not yet part of the new online scheme.
- Track finding doesn't work with the produced hits. Despite the hits looking correctly.
Merge request reports
Activity
@f.uhlig MR fails the code format check. However, running the code format script locally does not produce any changes for me. Do you have an idea what could be the cause?
- Resolved by Felix Weiglhofer
Which clang-format version do you use?
The problem is a crash when running CMake
CMake Error at reco/detectors/sts/CMakeLists.txt:124 (xpu_attach): Unknown CMake command "xpu_attach".
You can check the results on the CDash webpage
https://cdash.gsi.de/index.php?project=CbmRoot
in the Checks section.
I have an idea what the problem could be but can check only tomorrow.
I think the issue is fixed with !847 (merged). After the MR is merged rebasing this MR should pass the code format checker.
added 4 commits
-
9d176593...5de9072a - 2 commits from branch
computing:master
- c7dcd069 - gitignore: Add vscode folder.
- 610d33a7 - StsReco: Add GPU Hitfinder besides existing local reconstruction.
-
9d176593...5de9072a - 2 commits from branch
added 1 commit
- a7ab77f0 - StsReco: Add GPU Hitfinder besides existing local reconstruction.
added 1 commit
- 6227ed63 - StsReco: Add GPU Hitfinder besides existing local reconstruction.
requested review from @v.friese
added 1 commit
- 765265bb - StsReco: Add GPU Hitfinder besides existing local reconstruction.
added 1 commit
- db55c5ec - StsReco: Add GPU Hitfinder besides existing local reconstruction.
added 1 commit
- 4a6c5589 - StsReco: Add GPU Hitfinder besides existing local reconstruction.
added 1 commit
- 42563648 - StsReco: Add GPU Hitfinder besides existing local reconstruction.
Dear @f.uhlig, @v.friese, @p.-a.loizeau, @se.gorbunov, @v.akishina,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
what finally fixed the problem with the installation test? Unfortunately you forced push such that the individual changes from on pipeline to the next one are not seen.
@f.uhlig: I did multiple things:
- Added a basic install command to xpu
- The header files in the experimental folder needed a manual install statement
- Omitted the
experimental/
-prefix when including files from that folder.