Update flesnet version in cbmroot
-
Review changes -
-
Download -
Patches
-
Plain diff
To make the new algorithms work efficiently with mCBM, we still need to include the "new" flesnet timeslice API in cbmroot. This MR is meant to update the external Flesnet reference to the current version.
The difficulty is that the interface has changed so much internally that updating the git hash is unfortunately not enough:
- Since the new version is directly connected to the shared memory, it internally uses significantly more code from the Flesnet repository. Therefore, it is no longer sufficient to just include the lib/fles_ipc subdirectory, we need more parts. My suggestion would be to include Flesnet completely analogous to the other external packages and to compile only the relevant parts possibly via build parameters as a build time optimization.
- As a further complication the interface needs a specific version of the ZeroMQ library built in a very recent version and with customized build parameters. To avoid conflicts with other versions, I solved this in the Flesnet repository by including ZeroMQ as an external package in the CMake buildflow and linking it statically. For this we would need a corresponding solution in cbmroot.
- The additional flesnet code parts are C++-17 and therefore the interface cannot be compiled with an older language standard.
Edited by Florian Uhlig
Merge request reports
Compare and
- version 237c2e1c01
- version 22b8d9d985
- version 219c869589
- version 200c883e10
- version 19dbe73e81
- version 180798a3e2
- version 170798a3e2
- version 16fdba4977
- version 1503156eec
- version 14a502b852
- version 13e64b62eb
- version 1234890019
- version 11b9b5515b
- version 10f27c2b61
- version 97060900e
- version 825ac20f6
- version 7e7ba4199
- version 61d6ad18a
- version 592d368d6
- version 4a6574b57
- version 315c5b494
- version 297b730f4
- version 1c3c7c8db
- master (base)
- latest version60b924f79 commits,
- version 237c2e1c019 commits,
- version 22b8d9d98511 commits,
- version 219c86958911 commits,
- version 200c883e1010 commits,
- version 19dbe73e819 commits,
- version 180798a3e218 commits,
- version 170798a3e218 commits,
- version 16fdba497718 commits,
- version 1503156eec17 commits,
- version 14a502b85216 commits,
- version 13e64b62eb15 commits,
- version 123489001914 commits,
- version 11b9b5515b14 commits,
- version 10f27c2b6113 commits,
- version 97060900e12 commits,
- version 825ac20f611 commits,
- version 7e7ba419911 commits,
- version 61d6ad18a11 commits,
- version 592d368d610 commits,
- version 4a6574b579 commits,
- version 315c5b4949 commits,
- version 297b730f48 commits,
- version 1c3c7c8db7 commits,
Compare changes
- Side-by-side
- Inline
Files
37Loading