Developing the TRD(2D) detector as intermediate tracker

Dear @a.bercuci, @p.kaehler,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

changed the description

added 14 commits

c0ed3568...d4a156d1 - 10 commits from branch computing:master
b807ad27 - rename simulator for TRD-2D
954704f6 - generate the default asic parameters according to the new scheme (only
c312f7b6 - add extra it definitions nissing in the last commit. Fix format
eeb020c9 - add TrdHit QA data class which packs the whole history of a

Compare with previous version

added 10 commits

eeb020c9...e13ab847 - 4 commits from branch computing:master
41282a97 - rename simulator for TRD-2D
cb0adf78 - generate the default asic parameters according to the new scheme (only
8e9a2d4f - add extra it definitions nissing in the last commit. Fix format
902a3c7f - add TrdHit QA data class which packs the whole history of a
ffb46a2e - improve verbosity, save more cluster data for further processing
c0a1872d - extend the TrdHit Qa data class for digi signals and clusters

Compare with previous version

added 26 commits

c0a1872d...66f00fbc - 16 commits from branch computing:master
7a12e718 - rename simulator for TRD-2D
cabb2b1a - generate the default asic parameters according to the new scheme (only
91359c29 - add extra it definitions nissing in the last commit. Fix format
baa6ba7a - add TrdHit QA data class which packs the whole history of a
69b06899 - improve verbosity, save more cluster data for further processing
1ea0c5b3 - extend the TrdHit Qa data class for digi signals and clusters
2f954543 - add noise:
cdf6b1a2 - add global parameter for FASP signal/channel noise
17e91e24 - store digits on the QA structure to complete the history of
f3633b0c - add verbosity, fix format

Compare with previous version

marked the checklist item run the global tracker using the position information for TRD(2D) from MC points. as completed

added 58 commits

f3633b0c...0f57474d - 46 commits from branch computing:master
704b5adc - rename simulator for TRD-2D
51535488 - generate the default asic parameters according to the new scheme (only
7bf5d6ac - add extra it definitions nissing in the last commit. Fix format
3717739f - add TrdHit QA data class which packs the whole history of a
2efd1a50 - improve verbosity, save more cluster data for further processing
5375df4c - extend the TrdHit Qa data class for digi signals and clusters
9826fc66 - add noise:
d7a94993 - add global parameter for FASP signal/channel noise
fe3831c4 - store digits on the QA structure to complete the history of
95e3503f - add verbosity, fix format
d27010e6 - revert changes in the general infrastructure (TrackerInputQa) and move
dbe6c744 - Add new tracker calibration class for TRD system to be used to adjust

Compare with previous version

changed title from Draft : Developing the TRD(2D) detector as intermediate tracker to Developing the TRD(2D) detector as intermediate tracker

approved this merge request

Hi @se.gorbunov

The code is now independent from the L1 tracker as we have discussed. I have moved everything to the TRD directory. A fix for the x pulls as requested by @v.akishina (e.g. in her talk during 39th CBM Meeting) is included in this version. Please have a look and let me know whom else should approve in order to get in the master

Best

Alex

approved this merge request

Hi @a.bercuci ,

I think we can merge, but first you need to fix a failed test: https://cdash.gsi.de/testDetails.php?test=11643715&build=332383

/Users/fairroot/builds/a.bercuci/cbmroot/core/data/test/trd/_GTestCbmTrdHit.cxx:131: Failure Expected equality of these values: "CbmPixelHit: address=12345 pos=(-3,5.777,123.765) " "err=(0.77,0.88,0.99) dxy=1.2 refId=6\nCbmTrdHit: " "time[ns]=456+-1.34 eloss=123 typ[R] RC=n Ovf=n\n" Which is: "CbmPixelHit: address=12345 pos=(-3,5.777,123.765) err=(0.77,0.88,0.99) dxy=1.2 refId=6\nCbmTrdHit: time[ns]=456+-1.34 eloss=123 typ[R] RC=n Ovf=n\n" test.ToString().c_str() Which is: "CbmPixelHit: address=12345 pos=(-3,5.777,123.765) err=(0.77,0.88,0.99) dxy=1.2 refId=6\nCbmTrdHit1D: time[ns]=456+-1.34 eloss=123 RC=n Ovf=n\n" With diff: @@ -1,2 +1,2 @@ CbmPixelHit: address=12345 pos=(-3,5.777,123.765) err=(0.77,0.88,0.99) dxy=1.2 refId=6 -CbmTrdHit: time[ns]=456+-1.34 eloss=123 typ[R] RC=n Ovf=n\n +CbmTrdHit1D: time[ns]=456+-1.34 eloss=123 RC=n Ovf=n\n

added 1 commit

d7d0c442 - fix test for new ToString function implementation

Compare with previous version

added 1 commit

1237448a - try fix test on the ToString call

Compare with previous version

added 18 commits

1237448a...12609505 - 4 commits from branch computing:master
4638bebc - rename simulator for TRD-2D
0188b630 - generate the default asic parameters according to the new scheme (only
fde63b8e - add extra it definitions nissing in the last commit. Fix format
00db747b - add TrdHit QA data class which packs the whole history of a
380273b2 - improve verbosity, save more cluster data for further processing
80f724c5 - extend the TrdHit Qa data class for digi signals and clusters
20de2c1d - add noise:
d54833eb - add global parameter for FASP signal/channel noise
6f83f22f - store digits on the QA structure to complete the history of
df3840aa - add verbosity, fix format
fbaafdc0 - revert changes in the general infrastructure (TrackerInputQa) and move
0a121df0 - Add new tracker calibration class for TRD system to be used to adjust
7d27953b - fix test for new ToString function implementation
7d077023 - try fix test on the ToString call

Compare with previous version

resolved all threads

added 15 commits

5acfd390 - 1 commit from branch computing:master
877b90ca - rename simulator for TRD-2D
b4e259d0 - generate the default asic parameters according to the new scheme (only
b8314c09 - add extra it definitions nissing in the last commit. Fix format
3ddbba16 - add TrdHit QA data class which packs the whole history of a
6e7750b8 - improve verbosity, save more cluster data for further processing
4a42841f - extend the TrdHit Qa data class for digi signals and clusters
f1712ac0 - add noise:
7f28811e - add global parameter for FASP signal/channel noise
37c26262 - store digits on the QA structure to complete the history of
f2a159f2 - add verbosity, fix format
1f7096e3 - revert changes in the general infrastructure (TrackerInputQa) and move
06c2e1a6 - Add new tracker calibration class for TRD system to be used to adjust
61544261 - fix test for new ToString function implementation
657e3a05 - try fix test on the ToString call

Compare with previous version

assigned to @se.gorbunov

added 18 commits

657e3a05...c3875e0b - 4 commits from branch computing:master
26943f6e - rename simulator for TRD-2D
8a622994 - generate the default asic parameters according to the new scheme (only
344e795f - add extra it definitions nissing in the last commit. Fix format
5758cc4c - add TrdHit QA data class which packs the whole history of a
add4339b - improve verbosity, save more cluster data for further processing
4c853da9 - extend the TrdHit Qa data class for digi signals and clusters
8fb91ca3 - add noise:
69c914dd - add global parameter for FASP signal/channel noise
69b3fd07 - store digits on the QA structure to complete the history of
11d516a9 - add verbosity, fix format
fdea0a65 - revert changes in the general infrastructure (TrackerInputQa) and move
b9ca983d - Add new tracker calibration class for TRD system to be used to adjust
c39a17ca - fix test for new ToString function implementation
bf6a2a95 - try fix test on the ToString call

Compare with previous version

Developing the TRD(2D) detector as intermediate tracker

The following open issues are to be solved:

Activity

Developing the TRD(2D) detector as intermediate tracker

The following open issues are to be solved:

Merge request reports

Activity