Skip to content
Snippets Groups Projects

mSTS and mMUCH changes from march 2022 runs

Merged Pierre-Alain Loizeau requested to merge mcbm/cbmroot:5-msts_mmuch_changes into master
All threads resolved!

Introduces support for mMUCH unpacking in the CRI world + working online monitoring for both systems + various fixes (see commits messages)

Draft status: To be rebased (should be trivial) and merged only after !809 (merged) is merged

Reviewers: @a.toia and @v.singhal (not assigning as both approval needed in my opinion)

Edited by Pierre-Alain Loizeau

Merge request reports

Merge request pipeline #17226 passed

Merge request pipeline passed for d64b28bf

Approval is optional

Merged by Pierre-Alain LoizeauPierre-Alain Loizeau 3 years ago (May 5, 2022 3:05pm UTC)

Merge details

  • Changes merged into master with d64b28bf.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #17233 passed

Pipeline passed for d64b28bf on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Pierre-Alain Loizeau resolved all threads

    resolved all threads

  • Dear @f.uhlig, @v.friese, @p.-a.loizeau, @v.singhal,

    you have been identified as code owner of at least one file which was changed with this merge request.

    Please check the changes and approve them or request changes.

  • requested review from @v.singhal

  • added 8 commits

    • d32603f2 - 1 commit from branch computing:master
    • 66cc14a9 - Add MUCH unpacking
    • 410a4145 - [mSTS] Add new parameter files for 2022
    • 4767c97e - [mSTS][mMUCH] Fixes to get the monitors running
    • 3413aebc - [mMUCH] Added Pulser branch support and new Par File with Par File setter in MuchConfig
    • 7331b5af - [mMUCH] In unp algo, do not print address warning for pulser digis
    • 4a1cec2c - Add missing dict for error msg vector + improve error flag handling in mSTS unp
    • 7d715d9c - [mMuch] Fix par file setting in unpack algo-conf + fix par file

    Compare with previous version

  • Florian Uhlig added 8 commits

    added 8 commits

    • 90ec7a7b - 1 commit from branch computing:master
    • ded606b8 - Add MUCH unpacking
    • 6e54816b - [mSTS] Add new parameter files for 2022
    • a179c1ec - [mSTS][mMUCH] Fixes to get the monitors running
    • 2169676a - [mMUCH] Added Pulser branch support and new Par File with Par File setter in MuchConfig
    • 7d85d0f9 - [mMUCH] In unp algo, do not print address warning for pulser digis
    • 57e08c82 - Add missing dict for error msg vector + improve error flag handling in mSTS unp
    • b48a1031 - [mMuch] Fix par file setting in unpack algo-conf + fix par file

    Compare with previous version

  • added 10 commits

    • b48a1031...66f00fbc - 9 commits from branch computing:master
    • d64b28bf - [mSTS][mMUCH] Fixes to get the evolution plots in the monitors running

    Compare with previous version

  • Pierre-Alain Loizeau enabled an automatic merge when the pipeline for d64b28bf succeeds

    enabled an automatic merge when the pipeline for d64b28bf succeeds

  • The initial commits were included by mistake when merging !811 (merged) without rebasing it interactively first to change the order. The merging was however approved by both detectors responsible persons in the meantime.

    So for future reference, all commits tagged with [STS] or [MUCH] in !811 (merged) are described here

    The remaining commit is one which was planned to be added to this MR.

  • Please register or sign in to reply
    Loading