Skip to content
Snippets Groups Projects

Revise the build environment (Move to C++17)

Merged Florian Uhlig requested to merge f.uhlig/cbmroot:fix_cpp17 into master
All threads resolved!

Use C++17 as C++ standard for the compilation of CbmRoot. Check if compiler supports the C++17 standard. Check if also FairSoft was compiled with C++17. Check the required versions of ROOT (at least Root6), FairSoft( at least apr21) and FairRoot (at leass v18.6.7). If any of the checks fail stop the configuration with a meaningful error message. Remove some switches which are not needed any longer. Remove checks for C++11 features. No need to check them any longer, since the new standard is noe C++17.

Edited by Florian Uhlig

Merge request reports

Merge request pipeline #17089 passed

Merge request pipeline passed for ee2726f5

Merged by Volker FrieseVolker Friese 3 years ago (May 2, 2022 12:56pm UTC)

Loading

Pipeline #17093 passed

Pipeline passed for ee2726f5 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • All green for me aside the eventual comment to add one item to our ever increasing list of MQ TODO's :grin:

  • Pierre-Alain Loizeau approved this merge request

    approved this merge request

  • Pierre-Alain Loizeau mentioned in merge request !792 (merged)

    mentioned in merge request !792 (merged)

  • Florian Uhlig marked this merge request as ready

    marked this merge request as ready

  • Florian Uhlig added 8 commits

    added 8 commits

    Compare with previous version

  • Volker Friese resolved all threads

    resolved all threads

  • Volker Friese added 22 commits

    added 22 commits

    Compare with previous version

  • @f.uhlig @v.friese

    Could we please wait until we merge all mCBM related MRs before merging this one?

    I now have 12 "step-wise" branches there which will lead to 12 stand-alone but consecutive MRs, so rebasing all of them many times is getting more and more tedious

  • Pierre-Alain Loizeau resolved all threads

    resolved all threads

  • Volker Friese added 7 commits

    added 7 commits

    • 0ed706c1 - 1 commit from branch computing:master
    • 4ca2d650 - Remove leftovers which were needed for ROOT 5
    • 57b3caee - Revise the build environment
    • 69eec159 - Revise the build environment
    • 5223a6e6 - Improve installation instructions
    • a0d573f6 - Revise autoinstall script
    • ee2726f5 - Cleanup CI

    Compare with previous version

  • merged

  • Please register or sign in to reply
    Loading