Remove usage of deprecated functions
The templated functions Deserialize and Serialize of the FairMQ Device are marked deprecated. These templates acctually only forward the call to the BoostSerializer and RootSerializer classes which are part of FairRoot. Call these classes directly to remove deprectaion warnings.
Merge request reports
Activity
requested review from @p.-a.loizeau
assigned to @p.-a.loizeau
could you please test if the changes work as expected. If you confirm it I will remove the old code from the MR which is currently only commented.
I will try to have a look as soon as possible.
In fact, could we try to introduce this from the mCBM fork, at least for all the classes which are modified there? I fear otherwise the back and forth rebasing sequence will be complicated
That would probably leave in this MR only the classes in the
MQ/monitor
foldergood point. I will try how complicate the rebasing from/to the mcbm fork will be.
Rebasing the master branch of mcbm works nearly without manual intervention. The only thing to be fixed is the hash value of the external geometry repository. So I would propose to merge the MR in the master branch of the official repository and get the changes to the mcbm fork by a rebase.
Dear @f.uhlig, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
- Resolved by Pierre-Alain Loizeau
ok, I see that it is mostly the Histograms and Canvas transfer which are impacted. As this is mostly ROOT based, I do not expect troubles. I will try to test it with last year data tomorrow morning.
Edited by Pierre-Alain Loizeau
added 11 commits
-
ddb13283...e465a41f - 10 commits from branch
computing:master
- ac11a8fb - Remove usage of deprecated functions
-
ddb13283...e465a41f - 10 commits from branch
added 8 commits
-
ac11a8fb...a244d714 - 7 commits from branch
computing:master
- 38c214ec - Remove usage of deprecated functions
-
ac11a8fb...a244d714 - 7 commits from branch
- Resolved by Florian Uhlig
I let you remove the draft tag and rebase as I am not sure if you wanted to add more to the MR.
I will try to have a look at the MR tomorrow morning before packing my laptop to merge it in case it is ready.
mentioned in merge request !792 (merged)