Applying code format and change default time error according to new improvements in the time reconstruction in the CbmTrdModuleRecR
I tried to apply the correct code format with the clang-format installed in /cvmfs. Additionally, there is a small change in a default parameter for the EB-simulation and an adaptation of the time error according to the newest observations in simulation. The time error was overestimated now due to improvements in the time reconstruction step.
Merge request reports
Activity
I am a bit confused now... The pipeline failed and cdash reports problems with the MR-79. However, cdash reports 5 warnings with other classes. What did I do wrong here?
572 609 yVar = 0.0519485; 573 610 else if (errorclass == 4) 574 611 yVar = 0.0504586; 575 612 } I meant something like
static constexpr Double_t kxVar_Value[2][5] = { {0.0258725, 0.0267693, 0.0344325, 0.0260322, 0.040115}, {0.0426313, 0.0426206, 0.0636962, 0.038981, 0.0723851} }; static constexpr Double_t kyVar_Value[2][5] = { {0.024549, 0.025957, 0.0250713, 0.0302682, 0.0291146}, {0.0401438, 0.0407502, 0.0397242, 0.0519485, 0.0504586} };
in the header file with a proper comment what the numbers really mean. This shortens the code in the source file to
if (EB) { xVar = kxVar_Value[0][errorclass]; yVar = kyVar_Value[0][errorclass]; } else { if (EBP) time -= 50; //due to the event time of 0 in the EB mode and the ULong in the the digi time xVar = kxVar_Value[1][errorclass]; yVar = kyVar_Value[1][errorclass]; }
Edited by Florian Uhligchanged this line in version 2 of the diff
added 1 commit
- 28346d62 - Move parameters from the source code into the header file
added 12 commits
-
5a49de0a...6b9ae436 - 3 commits from branch
computing:master
- 34ef639d - Update in the EB time-reconstruction of the rectangular pads
- 99e76544 - add additional comment
- 770509f7 - Force new column (format)
- 75b388ca - apply format file correctly
- 10135797 - restore format
- ce22a8c3 - try to apply correct clang-format with version 8.0 this time
- 05f9e549 - Move parameters from the source code into the header file
- d9c8c3f5 - apply clang-format
- 3ecef138 - Merge branch 'master' of https://git.cbm.gsi.de/ebechtel_AT_ikf.uni-frankfurt.de/cbmroot
Toggle commit list-
5a49de0a...6b9ae436 - 3 commits from branch
added 1 commit
- 49fefcc9 - adding declaration in the source file and updating namespace calls for proper coding conventions
mentioned in merge request !792 (merged)