Macro for reconstruction from timeslices. Refs #2275.

added Framework Reconstruction labels

requested review from @p.-a.loizeau

assigned to @j.decuveland

Looks good and works for me! :-) Will merge when you approve, @p.-a.loizeau.

approved this merge request

Dear @f.uhlig, @v.friese, @p.-a.loizeau,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

Looks good for me.

One thing that could be nice if we want to use it for bigger mCBM sample, but that we should probably keep for a second version of the macro after testing it more extensively, would be

to make the macro main function to use a vector of tsa filenames and CbmSourceTs(std::vector<std::string> fileNames);
to add a second optional definition of this function taking the current single file name and making a vector out of it before calling the first version

=> That would be similar to what we do in run_unpack_tsa.C
=> The chained call unfortunately is more confusing for users when using the macro, as we learned with the mCBM macros

approved this merge request

Please wait with merging, there are still filenames hardcoded in the macro which I used for local testing. Will remove them asap.

added 1 commit

cdfc95f8 - Removed hard-coded file names.

Compare with previous version

changed title from Macro for reconstructon from timeslices. Refs #2275. to Macro for reconstruction from timeslices. Refs #2275.

resolved all threads

merged

mentioned in merge request !768 (merged)

Macro for reconstruction from timeslices. Refs #2275.

Merge request reports

Activity