Skip to content
Snippets Groups Projects

Initial version of STS unpacker algo plus integration by task. Refs #2268. Refs #2272.

Merged Volker Friese requested to merge v.friese/cbmroot:stsunpack into master
All threads resolved!

Formulation of the STS unpacker in the algo scheme with new API. Task (CbmUnpack) for execution in FairRunOnline. The macro reco/reco_unpack.C comprises only this unpacking task. The resulting CbmDigiTimelice objects are written to the output file.

The rather complicated STS DAQ mapping was separated from both algorithm and task. The interface is the mapping of equipment ID and elink (found in the raw data stream) to module address and ASIC number (for the digi address and channel number); this is hardcoded in the class StsReadoutConfig (based on CbmMcbm2018StsPar and macro/beamtime/mcbm2021/mStsPar.par).

The algorithm is formulated on the microslice level as smallest independently treatable data unit. The task instantiates, configures and executes one algorithm instance per component, an obvious parallelisation level. In principle, parallel execution could also be done on microslices within each component, but since the parameter set depends only on the component, this does not require separate algorithm instances.

Neither algo, task nor config are the final word on this, but this MR establishes the data and parameter interfaces and allows to independently debug and develop these components further.

On my MacBook, I measure some 300 ms per time slice in sequential processing (3 STS components, 1001 microslices each).

Refs #2268. Refs #2272.

Merge request reports

Merge request pipeline #16535 passed

Merge request pipeline passed for 70194e26

Approval is optional

Merged by Jan de CuvelandJan de Cuveland 3 years ago (Mar 11, 2022 9:04pm UTC)

Merge details

  • Changes merged into master with 70194e26.
  • Deleted the source branch.

Pipeline #16536 passed

Pipeline passed for 70194e26 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Volker Friese added 1 commit

    added 1 commit

    • 31344420 - Update following review by PAL.

    Compare with previous version

  • Florian Uhlig added 8 commits

    added 8 commits

    • 9d12c635 - 1 commit from branch computing:master
    • 8b8375df - First, boiled-down version of STS unpack algorithm. Neglects all monitoring...
    • e20b7360 - Modifications following the suggestions of P.-A. Loizeau and J. de Cuveland...
    • d7db9a22 - Fix CMakeLists.txt for StsXyter.h
    • f39bf522 - Initial version of STS unpacker plus integration by task. Refs #2268. Refs #2272.
    • fdbd3a29 - Added missing include (cassert); removed duplicated code from the task which...
    • 90a786b2 - Added missing class StsXyterMessage to library OnlineData.
    • c7e2e867 - Update following review by PAL.

    Compare with previous version

  • Jan de Cuveland
  • Jan de Cuveland
  • Jan de Cuveland
  • Jan de Cuveland
  • Volker Friese mentioned in merge request !761 (merged)

    mentioned in merge request !761 (merged)

  • Volker Friese added 27 commits

    added 27 commits

    • c7e2e867...aee14091 - 19 commits from branch computing:master
    • b75bdea5 - First, boiled-down version of STS unpack algorithm. Neglects all monitoring...
    • b1105c36 - Modifications following the suggestions of P.-A. Loizeau and J. de Cuveland...
    • 0ae5d75a - Fix CMakeLists.txt for StsXyter.h
    • 6a943a65 - Initial version of STS unpacker plus integration by task. Refs #2268. Refs #2272.
    • 80f32f15 - Added missing include (cassert); removed duplicated code from the task which...
    • f71b1de6 - Added missing class StsXyterMessage to library OnlineData.
    • ba022a43 - Update following review by PAL.
    • 41ce10b5 - Code improvements following review by JdC.

    Compare with previous version

  • Volker Friese added 1 commit

    added 1 commit

    • 61f4e095 - Improvement of time handling following review by PAL.

    Compare with previous version

  • Pierre-Alain Loizeau approved this merge request

    approved this merge request

  • Jan de Cuveland resolved all threads

    resolved all threads

  • Jan de Cuveland added 10 commits

    added 10 commits

    • 4585ae97 - 1 commit from branch computing:master
    • 46213614 - First, boiled-down version of STS unpack algorithm. Neglects all monitoring...
    • 28c3fd25 - Modifications following the suggestions of P.-A. Loizeau and J. de Cuveland...
    • d9115417 - Fix CMakeLists.txt for StsXyter.h
    • 49c0fed0 - Initial version of STS unpacker plus integration by task. Refs #2268. Refs #2272.
    • 5d675a0f - Added missing include (cassert); removed duplicated code from the task which...
    • 0a9e1237 - Added missing class StsXyterMessage to library OnlineData.
    • 71017efa - Update following review by PAL.
    • 39484791 - Code improvements following review by JdC.
    • 70194e26 - Improvement of time handling following review by PAL.

    Compare with previous version

  • Jan de Cuveland enabled an automatic merge when the pipeline for 70194e26 succeeds

    enabled an automatic merge when the pipeline for 70194e26 succeeds

  • Please register or sign in to reply
    Loading