Sts time walk correction
Merge request reports
Activity
assigned to @p.-a.loizeau
requested review from @v.friese
added 25 commits
-
72b3d1ec...ace65b25 - 23 commits from branch
computing:master
- fa15cef8 - Add Sts TimeWalk correction + parameter file mStsAsicTimeWalk.par
- e83f07bc - Apply clang-format
-
72b3d1ec...ace65b25 - 23 commits from branch
added Reconstruction mCBM labels
Dear @v.friese, @f.uhlig, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
- Resolved by Pierre-Alain Loizeau
So what this adds, is the option to read a set offsets from a file?
Seems ok to me. At the unpacker level these are low-risk changes in any case, as the walk correction can easily be switched off.
Just for clarification: The "polynomial fit of 3rd degree" is used to determine the parameters, but is not actually in the code, right?
- Resolved by Pierre-Alain Loizeau
- Resolved by Pierre-Alain Loizeau
- Resolved by Pierre-Alain Loizeau
- Resolved by Pierre-Alain Loizeau
@p.-a.loizeau : Looks ok. Small comments to the code in my review.
added 1 commit
- b568659a - Add Sts TimeWalk correction + parameter file mStsAsicTimeWalk.par
added 1 commit
- e283f472 - Add Sts TimeWalk correction + parameter file mStsAsicTimeWalk.par
enabled an automatic merge when the pipeline for e283f472 succeeds