Draft: Improve the handling of the TRD parameters and some othe minor code style improvements.

PAL edit 22/02/2024: Redmine refs #2646 #2853

Important remark this MR changes the IO of CbmTrdParSetAsic from the ascii parameter files. Thus, it needs to merged into the master in sync with the merge request CbmSoft/cbmroot_parameter!72 (closed) to the parameter repositor!

1. Drop unnecessary name tags for CbmTrd Asic type enum, since, the enum is part of CbmTrdDigi and thus, the tags are already part of the namespace of the enum.

2. Provide static helper function in CbmTrdGeoHandler, which extract the module type from the module label in our geometries.

3. Drop unnecessary name tags for HardwareSetupVersion enum ECbmTrdHardwareSetupVersion -> eHardwareSetupVersion

4. Add mcbm2021 component id setup to CbmTrdHardwareSetupR

5. Move functions creating the hardware to software address translation maps from CbmTrdHardwareSetupR to CbmTrdParSpadic and make them static. Allows to remove CbmTrdHardwareSetupR from the include files and the functions do not need to any class members. In addition the code handling the creation was further improved and trimmed down.

6. Trim down code in CbmTrdHardwareSetupR::WriteComponentIdsToParams()

7. Drop enum for component Id position composition and use static constexpr instead. Using an enum only assigning fixed numbers does not seem to be optimal. Thus, now static constexpr functions are used. The functions are emplaced in CbmTrdParAsic instead of CbmTrdParSpadic, since, the component Id itself is also stored their and the functionality should be common for Spadic and Fasp.

8. CbmTrdParFasp: remove casting in print statements and use correct variable place holders instead.

9. Adjust used types for GetNrChannels (former GetNchannels) functions in CbmTrdParAsic and the derived classes. The number of channels can not be negative and using a unsigned type here removes potential issues in comparing statements.

10. Implement a workaround for mcbm2021 where a 2D chamber was used with a Spadic in CbmTrdParManager::CreateModuleParameters, allowing correct automatic parameter creation.

11. Instead of using a hardcoded function returning the number of spadics on a chamber, this is now calculated based on the amount of channels on the chamber. (Mainly used in CbmTrdParManager)

12. CbmTrdParSet drop ROOT variable types together with RtypesCore include statement

13. CbmTrdParSetAsic adjust the code to further use range based loops, which should make the code more readable and less error prone. Adjust the code for changes in other classes. Drop const from return statement of CbmTrdParSetAsic::GetModuleSet, since this blocked static_casting and some stages, where it is required in the restructured code.

14. Drop NSPADICCH define statement in CbmTrdParSpadic and use a static constexpr in CbmTrdSpadic instead. This should be better handled by the compiler.

15. Add a safety to the unpacker which handles wrongly assigned eLinks in case of less than the maximum of eLinks are connected to a chamber. Now when a wrong eLink number is in a HitMessage it is the data is attached to a dummy eLink with the ID 99.

16. Change parameter setting for CbmTrdParSetAsic for asic type parameter to use the eAsicType enum instead of the module type. This change requires an update of all parameter files.

I would propose @a.bercuci as reviewer and add @a_meye37_AT_uni-muenster.de, @apuntke and @p.kaehler for the 1D group. I will still try to check it in the new year, but can not guarantee quick responding. Nevertheless, I think the updates will help, since, they also fix the automatic parameter creation for the TRD-1D for mCbm2021. Feel free to change things in the MR if you think changes are necessary.

Cheers and "einen guten Rutsch", Pascal

mentioned in merge request CbmSoft/cbmroot_parameter!72 (closed)

changed the description

I guess the tests fail due to the wrong parameter files, as mentioned above the changes in the container class require the updated parameters from CbmSoft/cbmroot_parameter!72 (closed) but I do not know how to fix this, since it is kind of the snake biting its own tail. May be @p.-a.loizeau can comment since I think its mostly the mCbm tests failing, due to this issue. As additional remark, this MR does not obviously not yet contain the update of the hash for the parameters.

Indeed, that happened already a few times with changes to the parameter classes.

I would say that the most practical sequence would be to review both in parallel as Florian already asked Alexandru, maybe with somebody testing it locally, then first merge the parameters one and finally add the hash update to this one.

As you ticked the box allowing us to modify the branch (thanks to have thought of it ), I think Florian or me can do it without you having to lose time on it.

@a.bercuci,

could you please review this merge request as well as the corresponding merge request which changes the parameter files.

Hi,

@apuntke also offered to contribute to the MR reviewing

Hello,

I cloned the current master in a clean directory and applied the merge request using

git fetch origin merge-requests/656/head:improveParHandlingTrd1D
git checkout improveParHandlingTrd1D

I also loaded the correct parameter-files from the MR 72 of the parameter repository in the same way. After compilation, the files in the parameter directory in the src directory as well as in the installation directory are in the new state after MR 72, ensured by checking e.g. line 11 and 12 of file trd_v21b_mcbm.asic.par, which have the following content:

  180 3 24 24 
Type of asics on nTh module (FASP = 1, SPADIC = 0):  Int_t \

I unpacked the TSAs and tried to run my analysis, but I do not get any digis or rawmessages for the TRD1D modules. The problem is that the function CbmTrdParSpadic::GetHwToSwAsicAddressTranslator returns a map with only 2 entries. When unpacking with debug-level 4, this is shown: [DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - spadicHwMap with 2 entries created (see below for a more detailed log) The reason seems to be that parasic->GetComponentId() is always 0.

[INFO] CbmTrdUnpackConfig::Init() ---------------------------------
[INFO] CbmTrdUnpackConfig::InitOutput(TrdDigi)
[INFO] CbmTrdUnpackConfig::InitOutput(CbmTrdRawMessageSpadic)
[INFO] CbmTrdUnpackConfig::registerBranchToTree(TrdDigi)
[INFO] CbmTrdUnpackConfig::registerBranchToTree(CbmTrdRawMessageSpadic)
[INFO] CbmTrdUnpackConfig::Init -
[INFO] CbmTrdUnpackConfig::chooseAlgo() - selected algo = CbmTrdUnpackAlgoR
[DEBUG] CbmRecoUnpack::Init - initParContainers
CbmTrdParSetAsic initialized from Ascii file
[INFO] CbmTrdUnpackAlgoR::Init()
[DEBUG4] CbmTrdUnpackAlgoR::Init - InitParContainers
[INFO] CbmTrdUnpackAlgoR::initParSet - for container CbmTrdParSetAsic
[DEBUG] CbmTrdUnpackAlgoR::initParSetAsic -
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 21000 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 21001 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 21002 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37000 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37001 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37002 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37003 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37004 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37005 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37006 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37007 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37008 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37009 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37010 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37011 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37012 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37013 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37014 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37015 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37016 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37017 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37018 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37019 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37020 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37021 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37022 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 37023 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53000 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53001 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53002 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53003 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53004 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53005 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53006 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53007 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53008 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53009 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53010 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53011 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53012 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53013 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53014 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53015 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53016 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53017 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53018 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53019 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53020 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53021 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53022 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - Adding asic with address 53023 and componentIds 0/1 to spadicHwMap
[DEBUG4] CbmTrdParSpadic::GetHwToSwAsicAddressTranslator - spadicHwMap with 2 entries created
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 21000 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 21001 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 21002 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37000 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37001 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37002 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37003 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37004 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37005 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37006 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37007 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37008 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37009 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37010 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37011 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37012 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37013 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37014 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37015 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37016 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37017 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37018 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37019 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37020 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37021 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37022 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 37023 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53000 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53001 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53002 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53003 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53004 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53005 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53006 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53007 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53008 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53009 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53010 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53011 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53012 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53013 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53014 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53015 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53016 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53017 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53018 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53019 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53020 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53021 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53022 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - Adding channel address vector (size64) for asic with address 53023 to spadicChannelsMap
[DEBUG4] CbmTrdParSpadic::GetAsicDigiChannelMap - spadicChannelsMap with 51 entries created
[INFO] CbmTrdUnpackAlgoR::initParSetAsic - Successfully initialized Spadic hardware address map
[INFO] CbmTrdUnpackConfigFasp2D::Init() ---------------------------------

Update: The Problem is that the new parameter files (CbmSoft/cbmroot_parameter!72 (closed)) contain wrong values of CriId, CrobId and ElinkId (all three are always 0) for the SPADICs. I tested it for TRD v20b.

Seems to be not defined, declared only.

I will try to look at it in the next weeks.

added 137 commits

• 8cf40344...384250a9 - 122 commits from branch computing:master
• b898d841 - Improve the handling of the TRD parameters and some othe minor code style improvements.
• 71935ed6 - Remove obsolete geometry macros for TRD
• b9b3f12e - Remove obsolete qa class
• 1e74edec - Add some helpers + shorten name enumerator
• c234f272 - Implement templates for parameter loading of TrdModules
• e775ff66 - Further improvements of ParAsic handling
• 10c33f71 - Implement getParams function for CbmTrdParSetGain
• 7d3d126f - Remove obsolete geometries for TRD
• 5285be45 - Remove outdated/obsolete trd mcbm geometries
• 22afb522 - Add mini helper checkig on CbmTrdPads
• ae95d6bb - Protect the fasp unpacker from a potential bug
• fac68d7e - Add correct handling of dummy eLink to getChannelId function
• 8f74c651 - Remove double defined GetAsicPar function + Add GetAsicName
• 98c60247 - Fix comment setence
• 7528d5b3 - Restructure parameter IO from/to FairParamList

Compare with previous version

assigned to @d.emschermann

Note from TRD meeting: work on this MR will be continued after current data analysis phase and after merging of the current geo/parameter stuff.

@p.kaehler,

I will set the MR in draft mode not to be always confused.

added 31 commits

• 7528d5b3...3d98e989 - 16 commits from branch computing:master
• f36ef516 - Improve the handling of the TRD parameters and some othe minor code style improvements.
• efc1bc6e - Remove obsolete geometry macros for TRD
• 2964c2aa - Remove obsolete qa class
• e2319a78 - Add some helpers + shorten name enumerator
• 84af8998 - Implement templates for parameter loading of TrdModules
• eef461d8 - Further improvements of ParAsic handling
• 6db6eaa5 - Implement getParams function for CbmTrdParSetGain
• f3bf62e0 - Remove obsolete geometries for TRD
• 0339ed0d - Remove outdated/obsolete trd mcbm geometries
• 7d1aa772 - Add mini helper checkig on CbmTrdPads
• e264cae0 - Protect the fasp unpacker from a potential bug
• cba3bb99 - Add correct handling of dummy eLink to getChannelId function
• f726c6c9 - Remove double defined GetAsicPar function + Add GetAsicName
• ecf4d385 - Fix comment setence
• 0a31955d - Restructure parameter IO from/to FairParamList

Compare with previous version

marked this merge request as draft

unassigned @d.emschermann

@trd,

should this MR still be merged or can it be closed? If it should be merged, this will be quite some work. Who will take care of this MR and the corresponding parameter MR?

We still have this merge request on the list, as it is valuable work, but it is not our first priority right now, as it interferes with the mCBM analysis which must be done now. We discussed it in the TRD meeting and it should stay open and we will come back to it later.

The TRD Group

changed the description

I think given that the branch was not rebased since more than a year before I tried it yesterday, is more than 1000 commits behind the current master and has conflicts with it, we should close this MR.
=> I think the changes will have to be re-implemented in a new branch based on the master, leading to a new MR.

The branch will still be available for reference in Pascal fork and I now added the two related issues I could find to the MR description so they get linked.

Let me know if you have other thoughts, otherwise I will close next week (we can always re-open it later if needed)

closed