WIP: Fix linking on macosx12
Somehow the dynamic linker on macosx 12 has changed. It now needs to resolve all symbols when loading a library such that all dependent libraries needs to be passed explicitly already when linking a new library. Before the linker was able to resolve such symbols if the needed library was in the library search path needed library was in the library search path.
Merge request reports
Activity
added BugFix Build System CI/CD labels
this MR should solve all issues with macosx12. Could you please try.
this MR splits KF into three separate libraries to solve the problem of the circular dependency between KF and L1. Please check if this is okay from your side.
@f.uhlig this is fine. We need to get rid of this circular dependency completely.
added 2 commits
added 12 commits
-
15c78e78 - 1 commit from branch
computing:master - 4e78877b - Fix linking on macosx12
- bc53bf0d - Fix linker problem with template function
- b5bb1aa8 - Remove circular dependency between KF and L1
- fd945331 - Adapt reco libraries to changes of KF
- 5767289d - Fix missing symbol in conversion library
- d95d820f - Use new enumerator correctly
- 02c1129b - Add fixes needed for macosx12
- 2886997c - Add Test stage for macosx12
- 01fd3d8c - Correct end of file
- 4c78211e - Fix script
- 813d05fd - More changes to fix linking
Toggle commit list-
15c78e78 - 1 commit from branch
@f.uhlig Thanks a lot Florian for your efforts! I tested everything and everything works fine! I think you can merge this MR.
unfortunately the MR introduces problems on Linux. I have to check them next week and try to fix them.
added 2 commits
Okay, we are down to two failing build stages.
The build and test for macosx12 actually works. The build stage is failing due to some problems to upload the results. Obviously there is some problem with the system curl version (https://stackoverflow.com/questions/69734654/fixing-git-https-error-bad-key-length-on-macos-12). Hope this can be fixed easily.
The build on Debian11 I have to check. There are problems to load many libraries. Maybe the problem is similar to the problem on Debian10.
added 16 commits
-
a8601a15 - 1 commit from branch
computing:master - 4e4b0863 - Fix linking on macosx12
- 6ff824e7 - Fix linker problem with template function
- d04ee287 - Remove circular dependency between KF and L1
- 8f33950e - Adapt reco libraries to changes of KF
- 394b24f4 - Fix missing symbol in conversion library
- 325f3df2 - Use new enumerator correctly
- 819264ed - Add fixes needed for macosx12
- 40155d1c - Add Test stage for macosx12
- 42aba87c - Correct end of file
- 9f891b53 - Fix script
- 8fc9d57f - More changes to fix linking
- 672b3d46 - Remove unnecessary include statements
- 12dbfebe - More changes to fix linking
- b6e576e9 - Fix clang format
- 3af9d5de - Use yet unofficial FairSoft version for Debian11
Toggle commit list-
a8601a15 - 1 commit from branch
Dear @f.uhlig, @v.friese, @p.-a.loizeau, @c.pauly, @i.selyuzhenkov, @se.gorbunov, @v.akishina, @s.lebedev, @n.herrmann, @i.deppner, @d.smith, @andrey.lebedev, @v.singhal, @praisig,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
@f.uhlig Changes are fine with me. My tests worked without problem on MacOs 12.
added 2 commits
mentioned in merge request !631 (merged)
This MR is superseded by !631 (merged) which is a cleaned version of this MR. This MR will be closed when the other is merged.
