Add dependency on boost_filesystem.

On MacOs the run_digi.C macro does not run due to errors while loading library. This MR fixes the problem.

added 1 commit

• fd3c4474 - Add missing dependency and link to ECbmRecoMode.

Compare with previous version

added 5 commits

• fd3c4474...b1e8b111 - 2 commits from branch computing:master
• a0aaf892 - Add dependency on boost_filesystem.
• 0be76dd1 - Add missing dependency and link to ECbmRecoMode.
• 25c38718 - LMVM: Use full name for enum.

Compare with previous version

added 1 commit

• 58bbf413 - Add missing dependency to TofReco.

Compare with previous version

Some additional information to this MR. Yesterday I updated operating system to MacOS 12. And most of the macros do not run now because of the problem with loading libraries. I'm fixing the problem with this MR.

Dear @f.uhlig, @v.friese, @p.-a.loizeau,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

added 1 commit

• 491cca43 - LitQa: add subdirectory to cmakelists

Compare with previous version

assigned to @f.uhlig

approved this merge request

@v.friese @f.uhlig

I still have problems running /macro/dielectron/run_litqa.C and run_ana.C

For the run_ana.C I have a problem loading libKF because some L1 methods are used. And if I try to add a dependency in KF I got a circular dependence between KF and L1:

CMake Error: The inter-target dependency graph contains the following strongly connected component (cycle): "KF" of type SHARED_LIBRARY depends on "L1" (strong) "L1" of type SHARED_LIBRARY depends on "KF" (weak) At least one of these targets is not a STATIC_LIBRARY. Cyclic dependencies are allowed only among static libraries. CMake Generate step failed. Build files cannot be regenerated correctly. make: *** [cmake_check_build_system] Error 1

Do you know how to solve this problem?

@s.lebedev,

which version of macosx, FairSoft and FairRoot do you use? I have never seen such problem.

I'm using MacOs 12.0.1, FairSoft apr21p1, FairRoot v18.6.4

The problem appeared after I updated to MacOs 12.

@s.lebedev

Nice that you also caught the TOF one, I had it in a branch but not yet in an MR. If you are interested in catching a few more missing dependencies, you can have a look at p.-a.loizeau/cbmroot@24ef3582

• The only remaining true miss is probably the one in PsdBase
• The one in RichReco is mostly removing relative path to sub-folders, which has far as I understood would be lost in the case of an installation

added 1 commit

• 205b22c8 - Add missing dependency in PSD and add path in RICH

Compare with previous version

@p.-a.loizeau

Thanks a lot, I also added your changes to this MR just not to have merge conflict.

@s.lebedev,

I wonder that you was able to compile ROOT. According to Mohammad who did upgrade some weeks ago the compilation did not work at all.

I think the failing Debian11 test managed to catch another implicit dependency: L1 CbmL1ReadEvent is using CbmTofDigiBdfPar and calling some of its methods but does not have CbmTofBase in its dependencies

What I do not see yet is how the other OS manage to get it... (maybe through 2 or 3 hops brought by KF?)

@f.uhlig I installed yesterday Fairsoft and Fairroot without any problem. It was also surprise for me that I was able to do it from the first time. The only problem now is that I could not run macro due to

library loading problem, symbol not found

I fixed it for run_tra.C, run_digi.C and run_reco.C see commits to this MR, in most cases it was a missing dependency. I could not fix it for run_litQa.C and analysis/dielectron/run_ana.C due to circular dependency in Lit and L1 and KF, respectively.

added 1 commit

• 9ba62349 - Add CbmTofBase to L1.

Compare with previous version