Major update of LMVM analysis.
Major update of LMVM analysis. Many improvements and changes. Many parts of the code were rewritten from scratch.
Merge request reports
Activity
Can you please help me with FileEndCheck and FileLicenceCheck? They are both failed and I do not know how to fix it.
The error message on the LicenceHeaderCheck points to problems with two files.
analysis/PWGDIL/dielectron/lmvm/LmvmDef.h
analysis/PWGDIL/dielectron/lmvm/LmvmUtils.cxxCorrect these in accordance with licence header format and this file check should pass.
Edited by Eoin Clerkinthe first thing to do is to check the output of the failing tests. You can find the complete pipeline at
https://git.cbm.gsi.de/s.lebedev/cbmroot/-/pipelines/13572
If you click on the failing test you see the needed output. For the FileEndCheck you see the files which does not end with an empty line. So simply add the missing empty line and you should be done. For the license header you have to fix the issues listed in the output which are marked with ERROR.
added 2 commits
I have a compilation error due to the usage of
<filesystem>. It is included in c++17 but as I found out the full support of c++ is available only starting from gcc 9 or even 9.1 (https://gcc.gnu.org/gcc-9/changes.html). Is it forseen to required c++17 and gcc 9.1 in the near future for cbmroot? or it is still not clear?Sure I can use some other methods instead of but I just want to clear this question.
Edited by Semen Lebedevunfortunately it is not possible to use C++17 features yet since our default FairSoft/FairRoot versions are still compiled with C++11. When we do the move to the latest FairSoft/FairRoot versions it will become possible to use C++17 features but probably only those which are supported gcc8 which is the default compiler for Debian10.
Would it be possible to use boost::filesystem as an alternative?
added 6 commits
-
b472c0c7...54df0e6d - 5 commits from branch
computing:master - b2b5ad49 - Major update of LMVM analysis.
-
b472c0c7...54df0e6d - 5 commits from branch
- Resolved by Semen Lebedev
@f.uhlig Yes, sure, I did it with boost.
- Last reply by Semen Lebedev
Dear @i.selyuzhenkov, @f.uhlig, @v.friese, @p.-a.loizeau, @s.lebedev,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
added 2 commits
