Reco trd2d

Add TRD2D reco algorithms for BOTH:

• simulating the mCBM setup '21 and '22

• testing the parallel track seeding procedure

Dear @praisig,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

assigned to @se.gorbunov

requested review from @praisig

Dear Alex,

please give some description what the new class CbmTrdDigiRec does and also add a Doxygen class description to the header file (@class CbmTrdDigiRec).

added 1 commit

• 6893586a - add extra algorithms for reconstructing TRD-2D hits

Compare with previous version

added 7 commits

• 6893586a...4d5bfe09 - 3 commits from branch computing:master
• 99e33b59 - add calibrated digi to be used in hit reconstruction
• 5e1ec1b4 - apply clang format on the new code
• 4374c937 - apply clang format
• eba059d5 - add extra algorithms for reconstructing TRD-2D hits

Compare with previous version

added 1 commit

• 7b373f63 - add macro to create TRD-2D geometry for the default(18) SIS100-electron

Compare with previous version

@a.bercuci,

could you please rebase your branch. Can be done by clicking on the Rebase button on the web page.

added 7 commits

• 7b373f63...0c8eb9c0 - 2 commits from branch computing:master
• f4288b1b - add calibrated digi to be used in hit reconstruction
• 7c2186b8 - apply clang format on the new code
• ef4d5e4f - apply clang format
• 17c8e570 - add extra algorithms for reconstructing TRD-2D hits
• 330c6773 - add macro to create TRD-2D geometry for the default(18) SIS100-electron

Compare with previous version

added 10 commits

• 330c6773...ade56a55 - 4 commits from branch computing:master
• 48a1e389 - add calibrated digi to be used in hit reconstruction
• 185ef4a6 - apply clang format on the new code
• ac68b6e3 - apply clang format
• ec52d03e - add extra algorithms for reconstructing TRD-2D hits
• 0edf5fb0 - add macro to create TRD-2D geometry for the default(18) SIS100-electron
• 8ca209e4 - fix clang format warnings

Compare with previous version

added 1 commit

• 17b7a3a2 - add licence

Compare with previous version

approved this merge request

added 10 commits

• 4d042e37 - 1 commit from branch computing:master
• 4c78a66f - add calibrated digi to be used in hit reconstruction
• 8be8df7f - apply clang format on the new code
• 58450095 - apply clang format
• 3ae9bd97 - add extra algorithms for reconstructing TRD-2D hits
• ba299b89 - add macro to create TRD-2D geometry for the default(18) SIS100-electron
• e31cdbc1 - fix clang format warnings
• 77baa22a - add licence
• 80061e57 - extend Merge function
• e6df5613 - add special entrance window for the TRD-2D detectors

Compare with previous version

added 16 commits

• e6df5613...43c581ba - 5 commits from branch computing:master
• e94565fd - add calibrated digi to be used in hit reconstruction
• ed496d15 - apply clang format on the new code
• b8d95644 - apply clang format
• e9409bd5 - add extra algorithms for reconstructing TRD-2D hits
• 55fbf24e - add macro to create TRD-2D geometry for the default(18) SIS100-electron
• 3911f0c7 - fix clang format warnings
• 08c8ee71 - add licence
• eb8ec216 - extend Merge function
• a7c485fe - add special entrance window for the TRD-2D detectors
• d4f5837b - extend simulation algorithm also for calibration data taking such as
• bae57b97 - add energy calibration function for converting signal (fC) to (keV)

Compare with previous version

added 1 commit

• 74765266 - fix clang format

Compare with previous version

Hi @a.bercuci, @v.friese , I have a general question to our calibration approach. To me the targeted way of calibration procedures always seemed to be to have fully calibrated digis after the unpacker. Now the CbmTrdDigiRec class implements an on-the-fly calibration stage for the TRD2D, which is never stored (or do I miss something here?). I do not have a strong opinion right now, which approach is better, but to me it seems to be quite different to what was done until now. Could you comment on if there is a general scheme how the calibration should be handled @v.friese? Do you see any drawbacks @a.bercuci, if you move the calibration into the unpacker instead of establishing an in-between digi stage?

As minor point, could you label the class with a 2D, because for the 1D case I do not see such an approach coming up, specially, since, it is not clear up to which stage we will have a preprocessing of the data on the fpga level. Therefore, we would like to keep everything changing the digis in the unpacker for the time being, such that it is easily exchangable.

I did try to go through the RecT changes, but with the kind of cryptic variable names it is quite difficult and time consuming to get a good picture what happens there. Nevertheless, this might also be due to my lack of detailed knowledge on the reconstruction steps you have to include there.

added 16 commits

• 74765266...5591bb48 - 4 commits from branch computing:master
• a0bdfc35 - add calibrated digi to be used in hit reconstruction
• 279cdb56 - apply clang format on the new code
• 4e02e2b0 - apply clang format
• 64a4aa3c - add extra algorithms for reconstructing TRD-2D hits
• 65453fb0 - add macro to create TRD-2D geometry for the default(18) SIS100-electron
• 2d6230bf - fix clang format warnings
• ff1ba846 - add licence
• 4c8e62c3 - extend Merge function
• ae55c1fb - add special entrance window for the TRD-2D detectors
• 08400b4c - extend simulation algorithm also for calibration data taking such as
• 93b92d69 - add energy calibration function for converting signal (fC) to (keV)
• 0dfbfef3 - fix clang format

Compare with previous version

added 34 commits

• 0dfbfef3...ee11f32b - 22 commits from branch computing:master
• 3ea3087a - add calibrated digi to be used in hit reconstruction
• cd658663 - apply clang format on the new code
• 6c5cbb53 - apply clang format
• 173be692 - add extra algorithms for reconstructing TRD-2D hits
• 300a657e - add macro to create TRD-2D geometry for the default(18) SIS100-electron
• facdbfec - fix clang format warnings
• 87cffe71 - add licence
• 59e59d91 - extend Merge function
• 9b4cc487 - add special entrance window for the TRD-2D detectors
• 7190459f - extend simulation algorithm also for calibration data taking such as
• e4fb8fa8 - add energy calibration function for converting signal (fC) to (keV)
• 386d4508 - fix clang format

Compare with previous version

added 38 commits

• 386d4508...22c9d45e - 27 commits from branch computing:master
• 69b1b44a - add calibrated digi to be used in hit reconstruction
• 3d4a9be2 - apply clang format on the new code
• 00375f5f - apply clang format
• 5bb38db0 - add extra algorithms for reconstructing TRD-2D hits
• f862bcc7 - add macro to create TRD-2D geometry for the default(18) SIS100-electron
• 19bb4cbe - fix clang format warnings
• 1ee7b058 - add licence
• 558958b8 - extend Merge function
• a7d361ef - add energy calibration function for converting signal (fC) to (keV)
• 900b95fa - add also calibration measurement support
• 5d0db0ed - fix format for previous commit

Compare with previous version