Improve script
Add / as allowed character in the regex which checks the copyright statement. This is needed since we have cases with two institutes and two cities in the copyright statement which are separated by a /.
Merge request reports
Activity
Dear @f.uhlig, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
- Resolved by Florian Uhlig
I don't think this is needed as when the committer has two affiliations, the correct syntax is the abbreviated form of the two institutes, separated by a comma and space, e.g.
PI-Uhd, GSI
Can you give me the example of a file where this is needed?
I do see one GSI/JINR-LIT but this is wrong, it should be GSI, JINR-LIT in which case we still need to change the regex to allow a dash after the comma. There will definitely need to be some changes to this regex over the next few days.
- Resolved by Florian Uhlig
Not sure if this should go in this MR: the script does not automatically compare to upstream when used locally under Ubuntu 20. It seems that one needs there to add a check that
$# -gt 0
to the if condition at l.61, so that the content of$1
is really filled (probably they initialize the $n to empty string by default...)Edited by Pierre-Alain Loizeau
added 4 commits
-
30f04e7c...4bc7013a - 3 commits from branch
computing:master
- 2a48a6d6 - Improve script
-
30f04e7c...4bc7013a - 3 commits from branch