Fix a performance issue with KFParticle
It was found that switching form FairSoft jun19p2 to nov20 or apr21 has a dramatic influence on the performance of the KFParticleFinder. The runtime for on of the tests increased by roughly a factor 16. https://redmine.cbm.gsi.de/issues/2220 After long investigations it turned out that the compilation flags for the package were inherited from the ROOT and the CbmRoot project which switched of the performance flag "-O" when using FairSoft nov20 or apr21. The merge request fixes the issue by defining the CMAKE_BUILD_TYPE explicitely to be RelWithDebugInfo. The merge request also updates the VC version from 1.4.1 to 1.4.2. refs #2220
Merge request reports
Activity
added BugFix Build System Reconstruction labels
enabled an automatic merge when the pipeline for a4b28326 succeeds
there is a strange problem with the loading of one of the libraries which I don't understand and which I can't reproduce on my mac. Because of the needed investigations I canceled the automatic merging.
added 7 commits
-
62169783...c807a369 - 6 commits from branch
computing:master
- 06b9555f - Fix a performance issue with KFParticle
-
62169783...c807a369 - 6 commits from branch
Dear @f.uhlig,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
to get the fix in as early as possible I went back to Vc 1.4.1 which is the same version as used in ROOT.
The problem to load some of our libraries due to a mismatch of Vc versions does not appear for all tested platform so I am still looking for the underlying issue, but up to now I wasn't able to find the cause of the problem.
@f.uhlig ok, should I merge it now with Vc 1.4.1 ?
if the fix is fine with you please merge the MR.
I am still working on the other issue and probably found the underlying reason for the problem. I will create another MR to update the VC version and correct our build system.
added 2 commits
enabled an automatic merge when the pipeline for bfcc4b60 succeeds