Update comb. BG procedure and add single particle yield analysis
Merge request reports
Activity
@cornelius.riesen_AT_physik.uni-giessen.de,
thanks for the fast action. Since the problem appeared again it is probably a good idea to start with a fresh working directory after the MR has passed.
Dear @i.selyuzhenkov,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
could you please confirm that the changes are okay. If I am correct you and Elena were the original authors of the code.
added 2 commits
thanks for approval. I will merge it when the pipeline succeeds.
@cornelius.riesen_AT_physik.uni-giessen.de,
please check your code again and probably create another MR. On CDash I saw the following warnings which should be taken seriously. Probably you mixed up == and =
[CTest: warning matched] /Users/fairroot/builds/computing/cbmroot/analysis/PWGDIL/dielectron/lmvm/CbmAnaDielectronTask.cxx:2669:36: warning: equality comparison result unused [-Wunused-comparison] if (particle == "rho0") particle == "inmed"; // or "inmed_had_epem"?? ~~~~~~~~~^~~~~~~~~~ [CTest: warning matched] /Users/fairroot/builds/computing/cbmroot/analysis/PWGDIL/dielectron/lmvm/CbmAnaDielectronTask.cxx:2669:36: note: use '=' to turn this equality comparison into an assignment if (particle == "rho0") particle == "inmed"; // or "inmed_had_epem"?? ^~ = [CTest: warning matched] /Users/fairroot/builds/computing/cbmroot/analysis/PWGDIL/dielectron/lmvm/CbmAnaDielectronTask.cxx:2671:14: warning: equality comparison result unused [-Wunused-comparison] particle == "omegadalitz"; ~~~~~~~~~^~~~~~~~~~~~~~~~ [CTest: warning matched] /Users/fairroot/builds/computing/cbmroot/analysis/PWGDIL/dielectron/lmvm/CbmAnaDielectronTask.cxx:2671:14: note: use '=' to turn this equality comparison into an assignment particle == "omegadalitz"; ^~ = [CTest: warning matched] /Users/fairroot/builds/computing/cbmroot/analysis/PWGDIL/dielectron/lmvm/CbmAnaDielectronTask.cxx:2673:14: warning: equality comparison result unused [-Wunused-comparison] particle == "omegaepem"; ~~~~~~~~~^~~~~~~~~~~~~~ [CTest: warning matched] /Users/fairroot/builds/computing/cbmroot/analysis/PWGDIL/dielectron/lmvm/CbmAnaDielectronTask.cxx:2673:14: note: use '=' to turn this equality comparison into an assignment particle == "omegaepem"; ^~ = [CTest: warning matched] /Users/fairroot/builds/computing/cbmroot/analysis/PWGDIL/dielectron/lmvm/CbmAnaDielectronTask.cxx:2675:14: warning: equality comparison result unused [-Wunused-comparison] particle == "qgp"; ~~~~~~~~~^~~~~~~~ [CTest: warning matched] /Users/fairroot/builds/computing/cbmroot/analysis/PWGDIL/dielectron/lmvm/CbmAnaDielectronTask.cxx:2675:14: note: use '=' to turn this equality comparison into an assignment particle == "qgp"; ^~ = [CTest: warning matched] 4 warnings generated.
[CTest: warning matched] /Users/fairroot/builds/computing/cbmroot/analysis/PWGDIL/dielectron/lmvm/CbmAnaDielectronTaskDrawAll.cxx:1711:14: warning: variable 'cock' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] else if (step == kPtCut) ^~~~~~~~~~~~~~ [CTest: warning matched] /Users/fairroot/builds/computing/cbmroot/analysis/PWGDIL/dielectron/lmvm/CbmAnaDielectronTaskDrawAll.cxx:1714:5: note: uninitialized use occurs here cock->Rebin(nRebin); ^~~~ [CTest: warning matched] /Users/fairroot/builds/computing/cbmroot/analysis/PWGDIL/dielectron/lmvm/CbmAnaDielectronTaskDrawAll.cxx:1711:10: note: remove the 'if' if its condition is always true else if (step == kPtCut) ^~~~~~~~~~~~~~~~~~~ [CTest: warning matched] /Users/fairroot/builds/computing/cbmroot/analysis/PWGDIL/dielectron/lmvm/CbmAnaDielectronTaskDrawAll.cxx:1689:15: note: initialize the variable 'cock' to silence this warning TH1D* cock; ^ = nullptr [CTest: warning matched] 1 warning generated.
@f.uhlig @cornelius.riesen_AT_physik.uni-giessen.de I plan in the next 3-4 weeks completely review and refactor LMVM analysis code. I propose to fix these warnings and then merge.
Edited by Semen Lebedev