Lean version of the new PSD unpacker in the scheme of CbmRecoUnpack

Based on CbmMcbm2018UnpackerAlgoPsd written by N. Karpushkin, already accommodating the new PSD raw data format (version 100).

It was stripped from parameter handling and monitoring and provides the interface required by CbmRecoUnpack (processing of a single component). The needed parameters (energy calibration channel-wise) are hard-coded in this first go. Also, the config scheme introduced by P. Raisig with the TRD unpacker is not yet adhered to; the class is directly hardwired to CbmRecoUnpack.

The digi times are relative to the current time slice start.

No backward compatibility to older PSD data formats,

added Reconstruction label

added mCBM label

Dear @karpushkin_AT_inr.ru, @f.uhlig, @v.friese, @p.-a.loizeau,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

Dear @v.friese , to my mind everything is correct, thanks!

By the way I think I managed to have the same implementation within the scheme. Even using the Parameter Class. @karpushkin_AT_inr.ru can you confirm that you currently use only the hardcoded parameters in CbmMcbm2018PsdPar and do not have any ascii files to load parameters from? So I only have to create that class correct?

The only issue is that I have to use some relative paths since not all headers can be loaded correctly (for me even the relative path in the CMakeLists.txt does not work)

Never mind I found the parameter file.

Should be macro/beamtime/mcbm2021/mPsdPar.par

added 1 commit

• 80945500 - Fix CMakeLists.txt (no relative path); removed unneccessary includes and forward declarations.

Compare with previous version

added 13 commits

• 80945500...489c6f7e - 9 commits from branch computing:master
• 0f99a514 - Lean version of the new PSD unpacker in the scheme of CbmRecoUnpack.
• f2a8c4fc - As usual, forgot formatting before committing...done now.
• 96226498 - Fix CMakeLists.txt (no relative path); removed unneccessary includes and forward declarations.
• 0a0b9a77 - Adjust to modified constructor of CbmPsdDsp.

Compare with previous version

I think you missed the include statement for unique_ptr.

#include <memory>

added 1 commit

• d22d5c6f - Missing include for unique_ptr.

Compare with previous version

I do not know what the plan to procede is here. Based on your exmaple I managed to include the Psd algorithm using the config scheme and its parameter files. You can find it in this branch https://git.cbm.gsi.de/praisig/cbmroot/-/tree/unpacker2021 Shall we still merge this one, or should I create a merge request? Or should I proceed on the branch until I have more unpackers in it?

The beam time will be over in some 6 hours. Our plan to have the new unpackers ready for (before) the beam time obviously failed. All we can do right now is to provide something running. So we should in the first place avoid to duplicate work and get the other unpackers running.

added 1 commit

• 4005d876 - Revert accidental previous commit.

Compare with previous version

Is this MR still actual? Or should I close it until we do a global modification of all unpackers at a later stage?

No, you are right. I withdraw the MR.

closed