New RICH unpacker for the new data format for 2021 beamtime.

• The old unpacker is still in the repository CbmMcbm2018UnpackerAlgoRich2020
• The old unpacker are still needed to analyze old data, later it will be removed

added 1 commit

• 2a4dfada - New RICH unpacker for the new data format for 2021 beamtime.

Compare with previous version

added 1 commit

• 7c6cb182 - New RICH unpacker for the new data format for 2021 beamtime.

Compare with previous version

@f.uhlig @v.friese

I think the clang-format checking is not correct. It indicates an error, for example here:

SubEventError = (uint16_t) ((dataPtr[0] >> 16) & 0xffff);

SubEventError = (uint16_t)((dataPtr[0] >> 16) & 0xffff);

The first line with space after uint16_t cast is mine, the second line without space is what expected to be. But according to .clang-flormat file my version is correct because SpaceAfterCStyleCast: true

Please help me to fix the problem.

added 1 commit

• 415f5ed0 - New RICH unpacker for the new data format for 2021 beamtime.

Compare with previous version

resolved all threads

added 2 commits

• 6b575da0 - 1 commit from branch computing:master
• ce6cb0f2 - New RICH unpacker for the new data format for 2021 beamtime.

Compare with previous version

added 1 commit

• 89a4d0c2 - clang-format

Compare with previous version

added 1 commit

• eae362a0 - New RICH unpacker for the new data format for 2021 beamtime.

Compare with previous version

I did cast with static_cast for the new code and switch off clang-format for the old unpacker.

We got some problems with the 2019/2020 data: https://cdash.gsi.de/viewTest.php?onlyfailed&buildid=279966

I think the unpacking unpack_tsa.C macros in the macro/run/mcbm2019 and macro/run/mcbm2020 should be tuned to make sure they use the old unpacker.

What is maybe weirder is that the old RICH monitors do not work anymore with 2019/2020 data: should they get the same changes as the 2018 one? or maybe some of the changes were added not on purpose?

The new unpacker supports only new data format from 2021. For the old data one should use CbmMcbm2018UnpackerAlgoRich2020.

Could you please do the following then:

• Make in macro/beamtime/mcbm2019/MonitorRich.C the necessary changes so that it use the old Algo
• Make in macro/beamtime/mcbm2019/unpack_tsa.C the necessary changes so that it use the old Algo
• Make in macro/beamtime/mcbm2020/MonitorRich.C the necessary changes so that it use the old Algo
• Make in macro/beamtime/mcbm2020/unpack_tsa.C the necessary changes so that it use the old Algo
• Add new macros MonitorRich.C and unpack_tsa.C (or modify the existing ones) in the macro/beamtime/mcbm2021 so that they use the new unpacker

@s.lebedev,

I have merged the PSD code. You can now update the RICH code.

added 19 commits

• eae362a0...4e961e83 - 18 commits from branch computing:master
• 68af28cf - New RICH unpacker for the new data format for 2021 beamtime.

Compare with previous version

For the old unpacker I also created separate class task class because I do not want to use some legacy code for the new unpacker. The classes for old unpackers will be removed as soon as they are not needed, new classes do not need to be changed then.

All build steps are now running. I had to add you to the runners.

requested review from @p.-a.loizeau

assigned to @p.-a.loizeau

added mCBM label

Dear @f.uhlig, @p.-a.loizeau,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.