setter for the default particle mass in L1 track fit; move global functions to L1Fit class

@v.akishina

• setter for the default particle mass for L1 track fit;
• global functions for material corrections from L1AddMAterial.h are moved to the new L1Fit class
• particle mass as a member of L1Fit, not as a parameter in function calls.
• remove default parameter values in the material routines in order to prevent bugs
• few bugfixes

Dear @se.gorbunov, @v.akishina,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

added 11 commits

• 7d043846...32e7a4d7 - 10 commits from branch computing:master
• a3196058 - setter for the default particle mass in L1 track fit; move global functions to L1Fit class

Compare with previous version

@v.akishina, I'll merge the MR, because I have other MR's that depend on it. If you want to change something, we can still discuss it here and merge it in a separate MR.

fine with me

enabled an automatic merge when the pipeline for a3196058 succeeds

aborted the automatic merge because target branch was updated

added 4 commits

• a3196058...bc211f36 - 3 commits from branch computing:master
• 8f3884d2 - setter for the default particle mass in L1 track fit; move global functions to L1Fit class

Compare with previous version

approved this merge request

Dear @se.gorbunov

Sorry for the probably stupid question, I just noticed that now the default value is muon mass and was wondering why? Before it was pion and I remember that the explanation was that it's the most abundant particle.

@se.gorbunov,

you can merge now.

@v.klochkov, It is not clear to me what was the default mass before:)

There are different sets of fit utilities with different default mass. In some places it was a pion, in others, it was a muon. I need to clean up the mess there.

In the track finder, the muon mass is used in order to not lose muons. Muons are a bit lighter than pions and therefore need more loose cuts. At the last iteration, the electron mass is used. Then during the final refit, both muon and pion masses were used at different places. Now it is at least consistent.

We need to think about the startegy, maybe one should create tracks using muon & electron masses but then refit them as pions..

I set default mass to muon, in order to get a good chi2 for both muons and pions. But currently, the pulls look bad independently on what default mass is used :) This needs to be investigated.

@se.gorbunov thank you for your answer! Probably it should be different for different setups, for example, if we run with a hadron setup maybe we shouldn't focus on muons more than on hadrons.

merged