Improvements to Algo and devices from MQ operation on mFLES and Virgo
Improvement to the T0 Monitoring Algorithm (operating in MQ mode) and to MQ devices found during the mTOF 03/2021 beamtime and the MQ on virgo
debugging phase
Corresponding MQ scripts for now not added to Cbmroot but stored in a personal project
Merge request reports
Activity
@f.uhlig No really important, but it seems our clang-format header rules is confused by the
BoostSerializer.h
andRootSerializer.h
fromFairMQ
. For now I just let it move them as it wants as the number of includes in the MQ devices cxx is not big.the commit is fine from my side.
Concerning the order of the header files you are right. The question is if it make sense to blow up the rules for this special case which is probably needed only in very few files.
Not sure indeed ^^
From what I could see in FairMQ only a few files haveFairMQ
in their name, so we would need to add almost all of them to the special ruleI think except if at some point clang-format adds a way to make some "russian dolls" set of rule files, it will be hard to catch all possible naming conventions of all external packages in a still readable way.
So I would leave the header order as is for now and review it only if someone later complains
Dear @f.uhlig, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
assigned to @f.uhlig