move warning in Trd-PID from calculation to init
Reduce the output that is created with each call of the probability calculation to the initialization of the respective histograms.
Merge request reports
Activity
@ebechtel_AT_ikf.uni-frankfurt.de and @praisig,
in my opinion this fix somehow hides the problem a little bit better then before. Instead of raising a warning thousand times it is done only ones. Wouldn't it be much better to cure the cause of the problem and provide proper input files with also muon data?
@f.uhlig ,
I agree that muon data should be added to the input, which will need a specific simulation to create the necessary statistics (especially for the momentum dependant case). However, it is still not useful for the warning to be shown with every probability calculation, since the input won't change after the start. Therefore, I would say this is still a good minor improvement.
Edit: the updated input will be pushed to the respective parameter file (when it was produced)
Edited by Etienne Bechtel@ebechtel_AT_ikf.uni-frankfurt.de,
I agree with your statement. If you are working also at an update of the parameter file I am fine with the commit.
Dear @praisig,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
Hi @ebechtel_AT_ikf.uni-frankfurt.de and @f.uhlig, since the TRD is not intended for Muon/Kaon/Proton ID adding correct input is kind of academic. I agree that we should provide this at some point, but it is kind of low on the priority list. Anyhow, I added it to my ToDo list, to not forget about. Otherwise the MR can be approved from my side. /approve
assigned to @se.gorbunov
@ebechtel_AT_ikf.uni-frankfurt.de,
please rebase.
- Resolved by Volker Friese
@ebechtel_AT_ikf.uni-frankfurt.de,
please wait with rebasing since Volker rebased another MR.
added 14 commits
-
7383e546...fd52c53e - 13 commits from branch
computing:master
- ddf53f6a - move warning in Trd-PID to reduce printing output in logs
-
7383e546...fd52c53e - 13 commits from branch
@ebechtel_AT_ikf.uni-frankfurt.de please, rebase
added 14 commits
-
ddf53f6a...40963796 - 13 commits from branch
computing:master
- 4308cd92 - move warning in Trd-PID to reduce printing output in logs
-
ddf53f6a...40963796 - 13 commits from branch
could you please merge.