Added files for BuildRawEvents FairMQ device. Updated CMakeLists.txt to include them.
A FairMQ device for the new event builder, and a bash script to execute it, which combines unpacking and event building. The present commit will not compile without the patch for the MVD libraries by @p.-a.loizeau , which will be submitted in a separate merge request.
The device was tested on two separate tsa files from lustre. It runs without crashing. Unfortunately, no events were found in either of the files, but this is consistent with the behavior of the old event builder.
The new device most likely works as it should, but more testing will be done. Any suggestions are welcome.
Merge request reports
Activity
- Resolved by Pierre-Alain Loizeau
@p.-a.loizeau Strangely enough, compilation succeeds on Mac without the patch. Probably the linker automatically detects the problem.
assigned to @v.friese
@d.smith MR !262 (merged) brought the fix in the master. If you rebase now it should work.
added 17 commits
-
9ce935e3...4740197f - 16 commits from branch
computing:master
- 70aede45 - Added files for BuildRawEvents FairMQ device. Updated CMakeLists.txt to include them.
-
9ce935e3...4740197f - 16 commits from branch
@f.uhlig @v.friese @p.-a.loizeau Removed WIP flag. With the MVD patch the present version should compile and can be merged in my opinion.
Edited by Dominik Smithadded 6 commits
-
70aede45...c3a119ac - 5 commits from branch
computing:master
- 26eeaf57 - Added files for BuildRawEvents FairMQ device. Updated CMakeLists.txt to include them.
-
70aede45...c3a119ac - 5 commits from branch
Dear @f.uhlig, @p.-a.loizeau, @v.singhal, @karpushkin_AT_inr.ru, @s.lebedev, @v.friese, @n.herrmann, @i.deppner, @praisig,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
in general it would be good to remove all the commented code. Either the code is needed and in that case it shouldn't be commented or it is not used and then the code should not be present at all.
added 1 commit
- d08c3ba4 - Added files for BuildRawEvents FairMQ device. Updated CMakeLists.txt to include them.
- Resolved by Volker Friese
@f.uhlig I now removed most of the commented out code (I left only some lines regarding the MVD which might be used at a later point).
@p.-a.loizeau I assume InitParameters() and InitContainer() was legacy code and is no longer needed. Also, there was some stuff about serialization of events and the reading of timeslice metadata. I removed this as well. Could you please confirm that we will not need any of this?
Currently a TClonesArray is used for the events at the FairMQ level, instead of a std::vector. I assume this is a contraint set by the framework at present.