Psd monitor cleanup + flags for light monitoring

assigned to @p.-a.loizeau

added 2 commits

• d8cb9140 - 1 commit from branch computing:master
• 227e5981 - Psd monitor cleanup + flags for light monitoring

Compare with previous version

approved this merge request

should I open an issue for the CodeFormatCheck?

Why do you want to open an issue?

because this job failed

You can either look at the needed changes in CDASH or with the script (this one needs to able to find clang-format and git-clang-format)

./scripts/check-apply-format-changes.sh check
./scripts/check-apply-format-changes.sh apply

You should correct the code format using the clang-format 11 binary from

https://redmine.cbm.gsi.de/projects/cbmroot/wiki/Clang-format

Or you can check the results of clang-format at

https://cdash.gsi.de/index.php?project=CbmRoot

in the "Checks" section and correct the problems manually. After fixing the issues in either way simply push the changes again to your branch on GitHub which will rerun the pipeline again.

Dear Pierre and Florian, Please help me figure it out. In the CDASH one can see these lines:

@@ -94,14 +86,10 @@ private:

advising to remove a "/n" before the fbMonitorChanMode. The reason I made it look that ugly is that a line above with fbMonitorMode was written exactly this ugly way. Please, believe me, it was originally written in one line, apparently there was automatic formatting at some stage.

You can find the same automatic code formating result in the Tof unpacker header

added 6 commits

• 227e5981...d30f9bab - 4 commits from branch computing:master
• 63faf2f9 - Psd monitor cleanup + flags for light monitoring
• 0bff4d8c - Apply clang-format

Compare with previous version

resolved all threads

@p.-a.loizeau, I started the canceled jobs such that the pipeline finally succeeds. If okay please merge the MR.

merged

@p.-a.loizeau, @karpushkin_AT_inr.ru,

I think I found a solution for the problem that git-clang-format uses the first clang-format it finds in the path. Actually it is possible to pass a parameter to git-clang-format which uses the defined clang-format.

Since the script already needs the clang-format specified by an environment variable it should be easy to add the parameter

--binary $CLANG_FORMAT_BIN

to the call of $GIT_CLANG_FORMAT_BIN to overcome the problem.

Could someone of you test if this would fix the problem on your installation and create a merge request in case the test is okay.