Skip to content

Deprecated cleanup: Old pre-CRI monitors, unpackers and event builders (fles folder)

Most of these files were developed during the SYSCORE and AFCK readout chains time.

Main rationals:

  • These files did not see any update since more than 3 years
  • These unpackers and monitors are 2 to 3 generations behind the current ones in the algo folder!
  • They were actually barely maintained and getting harder to keep compiling, not saying anything about working as not covered by any tests (see commits linked to recent GCC13-GCC14 deprecations)
  • We had longstanding warnings about some deprecation of the Flesnet sources for TS (TimesliceMultiSubscriber and TimesliceMultiInputArchive) and nobody with time to upgrade the code (see e.g. https://cdash.gsi.de/viewBuildError.php?type=1&buildid=536393)
  • The eTOF variant of MQ does not match anything used anymore in STAR (forked outward), and "latest" (relatively taken) versions are archived in https://git.cbm.gsi.de/etof/cbmroot-evtbuilder

=> One set of algo + task was moved to the reco/QA folder and library as it was updated in recent years by @a.bercuci and used in at least a few macros for mCBM 2024 data.

EDIT 20/11/2025: Changes to MQ folder removed from the MR as it still compiles without being forced to remove these classes. Will be independent MR to make it easier to handle.

Probably of Interest to:

  • @f.uhlig (for the long due cleanup of the repo and CMake)
  • @n.herrmann (I am not sure what the cleanup will do to his fork as these two root folders fles and MQ may have diverged strongly in his version)

Summary of changes (as the Gitlab MR UI seems overwhelmed with the number of files deleted when all commits are combined)

  • Renamed/moved from fles folder:
    reco/qa/CbmMcbmCheckTimingAlgo.cxx
    reco/qa/CbmMcbmCheckTimingAlgo.h
    reco/qa/CbmMcbmCheckTimingTask.cxx
    reco/qa/CbmMcbmCheckTimingTask.h
  • Deleted from `fles folder:
    fles/cosy2019 =>  16 files =>  7 classes
    fles/star2019 =>  25 files => 11 classes
    fles/mcbm2018 => 120 files => 59 classes
    • Including:
      fles/mcbm2018/monitor  => 48 files => 24 classes
      fles/mcbm2018/unpacker => 36 files => 18 classes
      fles/mcbm2018/tasks    => 26 files => 13 classes
  • Deleted from MQ folder:
    MQ/monitor    => 22 files => 6 startup scripts + 5 classes + 5 binaries
    MQ/unpacker   =>  3 files => 1 startup scripts                          + 2 parameter files
    MQ/hitbuilder =>  8 files => 8 startup scripts
    MQ/mcbm       =>  3 files => 3 startup scripts

Commands:

git diff --name-only --diff-filter=R upstream/master
git diff --name-only --diff-filter=D upstream/master | grep "fles/star" | grep -c ""
git diff --name-only --diff-filter=D upstream/master | grep "fles/star" | grep -c "\.h"
git diff --name-only --diff-filter=D upstream/master | grep "fles/cosy" | grep -c ""
git diff --name-only --diff-filter=D upstream/master | grep "fles/cosy" | grep -c "\.h"
git diff --name-only --diff-filter=D upstream/master | grep "fles/mcbm2018/" | grep -c ""
git diff --name-only --diff-filter=D upstream/master | grep "fles/mcbm2018/" | grep -c "\.h"

git diff --name-only --diff-filter=D upstream/master | grep "fles/mcbm2018/monitor" | grep -c ""
git diff --name-only --diff-filter=D upstream/master | grep "fles/mcbm2018/monitor" | grep -c "\.h"
git diff --name-only --diff-filter=D upstream/master | grep "fles/mcbm2018/unpacker" | grep -c ""
git diff --name-only --diff-filter=D upstream/master | grep "fles/mcbm2018/unpacker" | grep -c "\.h"
git diff --name-only --diff-filter=D upstream/master | grep "fles/mcbm2018/tasks" | grep -c ""
git diff --name-only --diff-filter=D upstream/master | grep "fles/mcbm2018/tasks" | grep -c "\.h"

git diff --name-only --diff-filter=D upstream/master | grep "MQ"

MR contains as first commit the content of !2223 (merged), as it needs it to pass the CI, and should therefore not be set out of Draft mode until this other one is merged => Done

Edited by Pierre-Alain Loizeau

Merge request reports

Loading