Draft: Add the new MUST detector system
This MR ist based on and supersedes !2040 Initially !2040 included also changes to the framework code of CbmRoot. These changes were properly separated and were added with !2101 (merged) such that !2040 only add the code for the new detector system. Beside these changes the current MR also does a lot of code cleanup to have a clean and streamlined code base for a new detector system.
Merge request reports
Activity
requested review from @p.-a.loizeau
assigned to @v.friese
please have a close look at this merge request. Since this is the first new detector system we add for some time we should take the time to check that the code is correct and complete such that the added code can serve as a template for other future systems.
Dear @f.uhlig, @v.friese, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
A first and general comment (also surpassing the scope of this MR).
We here (and in many other places) make use of
TVector3
. Now, in a recent discussion (see !2127 (merged) and #3625) I have learned that this class is deprecated andROOT::Math::XYZVector
should be used instead.Should we continue to commit new code with
TVector3
? I realize that replacement byXYZVector
is probably a major enterprise, since it involves also base classes in FairRoot (FairMCPoint
). But could we at least for our interfaces useXYZVector
?Edited by Volker FrieseI don't think this is a big issue here. If I am correct TVector3 is mostly used to store the 3 values of the position or momentum and is not used for any transformations. Changing the base class or any of our data classes using TVector3 might become complicated not to invalidate the existing data.
Another point which came to my mind is if we should start right away with std::vector as container. This is a new data class so we don not have to care about any legacy.
to your information. This is the MR which is build on top of your first implementation. Beside the changes you have already agreed on I have done some other minor modifications. If you find the time it would be great if you could have a look and provide some feedback.
mentioned in merge request CbmSoft/cbmroot_geometry!294
Reminder: as last step before merging the geometry MR CbmSoft/cbmroot_geometry!294 should be merged and the hash bump be added here
(one intermediate geometry hash bump MR will be needed before to avoid stacking too many unrelated geometry changes, this other MR should also bring the setup into the CI from what I discussed with Eoin)(Thanks @d.emschermann for the reminder that this was tracked in the superseded Cbmroot MR)
mentioned in merge request !2007
@f.uhlig , the MR looks good! Thanks for the update.
- Resolved by Florian Uhlig
Is there any activity on this long awaited MR? @v.friese @f.uhlig @p.-a.loizeau
added 98 commits
-
b792f0d3...643e9459 - 97 commits from branch
computing:master
- ca4cdd81 - Merge branch 'master' into 'must_simulation'
-
b792f0d3...643e9459 - 97 commits from branch
added 26 commits
- ca4cdd81...a7d948cd - 16 earlier commits
- 6cccabff - Code cleanup
- a3bc8dee - Code cleanup
- 850bae4d - Code Cleanup
- 2ad3cb05 - Code cleanup
- 4d0cabd0 - Code cleanup
- b87bb18f - Code cleanup
- 18d4bcf7 - Code cleanup
- 3100367a - Apply clang format
- 84ed5fe4 - Rich: bugfix for mRICH with updated CbmRichGeoHandler
- f8bbdb73 - Rich: CbmRichMCbmDenoiseCnn improve handling of invalid grind indices
Toggle commit listadded 26 commits
-
f8bbdb73...643e9459 - 2 commits from branch
computing:master
- 643e9459...bf6d76f9 - 14 earlier commits
- d6e3861c - feat(must): Replace TObjArray with std::vector for parameter storage
- 2b9df410 - Code cleanup
- 2e165727 - Code cleanup
- 21b64aff - Code cleanup
- 1a438917 - Code Cleanup
- 99436f4b - Code cleanup
- 29323034 - Code cleanup
- 64eb9f77 - Code cleanup
- 7a2274bf - Code cleanup
- 26921424 - Apply clang format
Toggle commit list-
f8bbdb73...643e9459 - 2 commits from branch
added 28 commits
-
26921424...baf41247 - 5 commits from branch
computing:master
- baf41247...cf2f9f74 - 13 earlier commits
- 89654146 - feat(must): Replace TObjArray with std::vector for parameter storage
- c18b7e27 - Code cleanup
- 139abb08 - Code cleanup
- b4faf29e - Code cleanup
- 1544c672 - Code Cleanup
- 97978cd9 - Code cleanup
- fa44091a - Code cleanup
- 45e94a47 - Code cleanup
- 9c7d7510 - Code cleanup
- 1a25ee2b - Apply clang format
Toggle commit list-
26921424...baf41247 - 5 commits from branch