Skip to content
Snippets Groups Projects

QA checker api

7 unresolved threads

The following parameters may be provided to compiled binary "hist_compare_api": -chash : for comparision of different commit hash. you should provide more than one hashs after this "-chash" flag -wtest : for comparision of weekly test. you should provide more than one week numbers (in yyyy_ww format) after -"-wtest" flag -config: provide the config file name only inside the config directory. It is optional parameter. If you don't want to compare commits or weekly test then you should only provide config file name with "- config" flag -output: for output file name(optional)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
76 continue;
77 }
78
79 // Replace file pattern inside "files:"
80 if (inFiles && trimmedLine.find("- name:") == 0) {
81
82 modifiedYaml << " - name: \"" << newFilePattern << "\"\n"; // Replace with new pattern
83
84 continue;
85 }
86
87 // Preserve other sections as-is
88 modifiedYaml << line << "\n";
89 }
90
91 file.close();
    • The file looks like an executable. Executables should not be submitted to source, but compiled automatically within the building (see my comment on the changing the macro above into the application in services directory)

    • Please register or sign in to reply
  • 21 echo "Installing CBMRoot..."
    22 ./install_cbmroot.sh || { echo "Installation failed"; exit 1; }
    23
    24 echo "Running Ctest"
    25 cd $build_dir
    26 ctest -R run_s100m3_qa_ts_eb_real
    27 cd macro/run/data
    28 #old_name="s100m3_qa_ts_eb_real.qa.root"
    29 #new_name="s100m3_qa_ts_eb_real_${short_com1}.qa.root"
    30 cp s100m3_qa_ts_eb_real.qa.root ${work_dir}/s100m3_qa_ts_eb_real_${short_com1}.qa.root
    31 echo "working dir : ${work_dir}"
    32 cd $work_dir
    33 }
    34
    35 # Initialize variables
    36 build_dir="/u/schattop/cbmroot_build/"
  • 235
    236
    237 }
    238 else{
    239 std::string yamlName =srcDir+"/configs/"+std::string(configName);
    240 std::string qacommand = std::string("root -l -q 'qa_compare_ca.C(\"") + yamlName + "\", \"" + outputName + "\")'";
    241 std::cout<<"Executing macro\t"<<qacommand<<std::endl;
    242 int returnMacro = std::system(qacommand.c_str());
    243 if (returnMacro != 0) {
    244 std::cerr << "Failed to execute: qa_compare_ca.C"<< std::endl;
    245 return 1;
    246
    247 }
    248
    249 }
    250 }
    • Comment on lines +239 to +250

      The macro qa_compare_ca.C is an example of using the qa-checker. You should not call macros from another macros or applications, if it is not necessary. Instead, provide a class (Application) into your app, and use the qa-checker classes there explicitly

    • Please register or sign in to reply
  • 33 if(compareCommit1==true){
    34 for (const auto &version : versionNames) {
    35 std::string label = version.substr(0, 9);
    36 std::string path = srcDir + "/s100m3_qa_ts_eb_real_" + label+".qa";
    37 modifiedYaml << " - label: \"" << label << "\"\n";
    38 modifiedYaml << " path: \"" << path << "\"\n";
    39 }
    40 }
    41 else{
    42 for (const auto &version : versionNames) {
    43 //std::string version=versionName[iv];
    44 std::size_t pos = version.find('_');
    45
    46 // Extract the year and week number
    47 std::string YEAR_ISO = version.substr(0, pos);
    48 std::string WEEK_ISO = version.substr(pos + 1);
    • Comment on lines +47 to +48

      Please use the following naming convention for variable names:

      YEARS_ISO -> yearsIso (or better sYearsIso) WEEK_ISO -> weekIso (or better sWeekIso)

    • Please register or sign in to reply
    Please register or sign in to reply
    Loading