Fix missing headers install
Add missing header in installation detected by the new test in !2064 (merged)
Draft mode until decision done on the 4 more complicated cases (no source dict, name collision, algo folder, externals)
Redmine: Refs #3582
Merge request reports
Activity
added BugFix Build System labels
requested review from @f.uhlig
assigned to @f.uhlig
- Resolved by Florian Uhlig
Dear @a.andronic, @k.piasecki, @f.uhlig, @v.friese, @p.-a.loizeau, @ma.beyer, @se.gorbunov,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
added 1 commit
- f91e13cf - Flatten KFParticle headers installation to match includes (and build folder)
- Resolved by Pierre-Alain Loizeau
With the last version I am down locally to only KFP and algo as missing headers/mismatching path. I will re-order and squash once we have a final version
mentioned in merge request p.-a.loizeau/cbmroot!6 (merged)
added 11 commits
-
d57c2518 - 1 commit from branch
computing:master
- fb459041 - Add missing installation of header only files in core
- c57962d9 - Add missing installation of header only files in reco
- 0151eb7a - Add missing installation of header only files in analysis
- 93c86d31 - Add installation of RICH fitter header same as others, strange as NO_DICT_SRCS
- 67e340d7 - Flatten KFParticle headers installation to match includes (and build folder)
- 6d7c7586 - Revert "Flatten KFParticle headers installation to match includes (and build folder)"
- 328e6355 - Additional missing header install in sim
- 6fe15419 - Additional missing header install in reco
- dd949876 - Additional missing header install in analysis
- 788577ba - Don't install conflicting header files
Toggle commit list-
d57c2518 - 1 commit from branch
You were faster than me
. I was planning to do the same as I think the pipeline will make sense only after I discuss with @s.zharko tomorrow how to address the two remaining problems with Algo-QA and how KFParticle is brought into Cbmrootadded 13 commits
-
788577ba...8324968b - 2 commits from branch
computing:master
- 7f37b40c - 1 earlier commit
- bbcc9615 - Add missing installation of header only files in reco
- 0529c294 - Add missing installation of header only files in analysis
- 30371e4f - Add installation of RICH fitter header same as others, strange as NO_DICT_SRCS
- 82fcca30 - Flatten KFParticle headers installation to match includes (and build folder)
- 8810249f - Revert "Flatten KFParticle headers installation to match includes (and build folder)"
- def9a430 - Additional missing header install in sim
- d23f2e87 - Additional missing header install in reco
- 92c2fc67 - Additional missing header install in analysis
- c4978027 - Don't install conflicting header files
- 881962cf - Apply to libCbmSimDigitizationSteer the Don't install conflicting header files patch
Toggle commit list-
788577ba...8324968b - 2 commits from branch
added 1 commit
- 5fd6179e - Apply to libCbmSimDigitizationSteer the Don't install conflicting header files patch
added 13 commits
-
5fd6179e...119d9884 - 2 commits from branch
computing:master
- 2b4749d2 - 1 earlier commit
- 5de33890 - Add missing installation of header only files in reco
- c91b64c4 - Add missing installation of header only files in analysis
- 956a0fbb - Add installation of RICH fitter header same as others, strange as NO_DICT_SRCS
- d2ba167c - Flatten KFParticle headers installation to match includes (and build folder)
- d9c72d45 - Revert "Flatten KFParticle headers installation to match includes (and build folder)"
- 78c3aee3 - Additional missing header install in sim
- 675c232e - Additional missing header install in reco
- cca2e9de - Additional missing header install in analysis
- 8b1890b9 - Don't install conflicting header files
- 6e1ffc6d - Apply to libCbmSimDigitizationSteer the Don't install conflicting header files patch
Toggle commit list-
5fd6179e...119d9884 - 2 commits from branch