Try to fix online-offline yaml include conflict in installed version
Redmine: Refs #3577
This is a more complete extension of the "quick and dirty" approach I mentioned in the issue, which cures the problem reported there
=> The MR is intended to cross-check whether this has some unintended side-effects
Edit 20-21/03/2025:
=> The MR evolved into a more reduced and cleaner fix, while still addressing the problem only for this occurrence and not in a generic/general way
=> More permanent solution will be something closer to a set of enforce conventions for the full codebase
Of interest to: @a.bercuci @fweig @v.friese @s.zharko (maybe also @f.uhlig for the not fully required cmake include variables cleanup)
Merge request reports
Activity
added BugFix Build System Online Reconstruction labels
assigned to @f.uhlig
added 1 commit
- 1d9692d4 - Remove relative include for YAML utilities everuwhere + missing deps + no CBMROOT_SOURCE_DIR
added 17 commits
-
1d9692d4...08ed1568 - 15 commits from branch
computing:master
- 2dbb518f - TEMP: try to fix the yaml include error reported by Alexandru
- 981c3093 - Remove relative include for YAML utilities everuwhere + missing deps + no CBMROOT_SOURCE_DIR
-
1d9692d4...08ed1568 - 15 commits from branch
added 1 commit
- 4d15b257 - Declare dependencies on CbmYamlInterface as INTERFACE
mentioned in merge request !2064 (merged)
added 4 commits
-
a8b7cad5 - 1 commit from branch
computing:master
- 43b1e77e - Fixes to dependencies on CbmYamlInterface and related include folders definition
- 8e8209b7 - make the CbmYamlInterface library use the same include with path convention as the rest of the code
- 5cc3a470 - Add pre-processor include guards in all of YAML interface lib files
Toggle commit list-
a8b7cad5 - 1 commit from branch
Dear @d.smith, @fweig, @se.gorbunov, @s.zharko, @n.herrmann, @i.deppner, @f.uhlig, @v.friese, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
- Resolved by Pierre-Alain Loizeau
The inclusion of guards seem to fix the problem for now. Please do not merge yet as I still try to find a way to test in a generic way for the problem in !2064 (merged)
requested review from @f.uhlig
added 4 commits
-
d8fd3803 - 1 commit from branch
computing:master
- ff4d0028 - Fixes to dependencies on CbmYamlInterface and related include folders definition
- 23e0325c - make the CbmYamlInterface library use the same include with path convention as the rest of the code
- 79b61e1d - Add pre-processor include guards in all of YAML interface lib files
Toggle commit list-
d8fd3803 - 1 commit from branch