Fix test for files with non ASCII characters
The previous check was to general since it catched also files were non ASCII characters are allowed (e.g. Latex files). Now test only for source code files and check for files which are of non ASCII type.
Merge request reports
Activity
added BugFix Code Styling labels
requested review from @e.clerkin
assigned to @p.-a.loizeau
mentioned in merge request !2054 (merged)
Dear @f.uhlig, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
mentioned in merge request !2058 (merged)
- Resolved by Eoin Clerkin
I don't think this is suitable. After MR- !2054 (merged) which removes non-ASCII file from repo. Previously using UTF-8 method introduced in !2054 (merged), I count the number of files in the repo that fail
.cxx 66
.h 67
.C 20
With MR this change
.cxx 68
.h 67
.C 22
I will have a further look.
- Resolved by Florian Uhlig
perl grep is not on lxbk1135 and probably similar
check-non-ascii-characters.sh: line 31: pcregrep: command not found
- Resolved by Eoin Clerkin
file ../analysis/common/analysis_tree_converter/CbmFsdHitsConverter.cxx
reports as data.
- Resolved by Florian Uhlig
- Resolved by Eoin Clerkin
Still problem with fles/mcbm2018/unpacker/CbmMcbm2018UnpackerAlgoRich2020.cxx
1737: // min. 1 rinǵ buffer overwritten
added 10 commits
-
17c5c4b9...7343ec13 - 9 commits from branch
computing:master
- 38b3ebd1 - Fix test for files with non ASCII characters
-
17c5c4b9...7343ec13 - 9 commits from branch
mentioned in merge request !2060 (merged)
Merging first as it is ready and approved, I will rebase !2060 (merged) and set it to auto-merge as soon as its initial pipeline is done
- Resolved by Florian Uhlig