Update RichGeoCreater file to create RICH geometry v25a
Changes from geometry v24a to v25a:
- Redesign of the mirror holders
- Replace old MirrorSupportBelts by new MirrorFixing which looks like the CAD model and the prototype
- Add a small plate at end of mirror support studs to fit the weight
- Fixing all overlaps in the geometry
- Fixing newly discovered bug in implementation of exit window
- change of geometry hierarchy at exit window
- similar change at entrance window to avoid potential of similar bug
- Additionally small changes (small regarding physics impact)
- changes in the volume hierarchy to reduce the depth
- changes in code of creator file to make it more efficient
- replacing some hard coded numbers by variables
- replacing double definitions of same volumes by copying
Additionally:
- Directly write (dummy) translation
TGeoTranslation
into geo file usingmacro/rich/create_rich_geo.C
Merge request reports
Activity
Dear @ma.beyer,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
assigned to @e.clerkin
- Resolved by Simon Neuhaus
- Resolved by Eoin Clerkin
- Resolved by Simon Neuhaus
- Resolved by Simon Neuhaus
- Resolved by Eoin Clerkin
Should the macro/rich/create_rich_geo.C file be moved to the geometry repository?
- Resolved by Simon Neuhaus
- Resolved by Simon Neuhaus
- Resolved by Eoin Clerkin
- Resolved by Simon Neuhaus
added 40 commits
-
232b7159...a8b7cad5 - 38 commits from branch
computing:master
- f8fbd7ab - update Geometry of Rich detector to version v25a
- e332afaf - small changes in coments and creation macro.
-
232b7159...a8b7cad5 - 38 commits from branch
- Resolved by Simon Neuhaus
added 6 commits
-
86fc4bff...79b61e1d - 3 commits from branch
computing:master
- 30fdb725 - update Geometry of Rich detector to version v25a
- 8bf59728 - small changes in coments and creation macro.
- a5d8cf51 - small changes reguested in merge request process.
Toggle commit list-
86fc4bff...79b61e1d - 3 commits from branch
mentioned in merge request CbmSoft/cbmroot_geometry!291 (merged)
- Resolved by Simon Neuhaus
Small overlap was detected.
Info in <TGeoNodeMatrix::CheckOverlaps>: Checking overlaps for cave and daughters within 0.0001 Info in <TGeoNodeMatrix::CheckOverlaps>: Checking overlaps by sampling <s1000000> for cave and daughters Info in <TGeoNodeMatrix::CheckOverlaps>: === NOTE: Extrusions NOT checked with sampling option ! === Info in <TGeoChecker::CheckOverlapsBySampling>: #Found 1 overlaps adding-up to 13.9259 +/- 6.96293 [cm3] for daughters of shielding_box Check overlaps: [==========] 573216 [100.00 %] 04:13 Info in <TGeoNodeMatrix::CheckOverlaps>: Number of illegal overlaps/extrusions : 1 Unexpected Overlap (sampled): = Overlap ov00000: Volume shielding_box: node shielding_box_part_1 overlapping shieling_wing_1 ovlp=0.000313625 Test failed We have in total 1 unexpected overlaps.
Can this be addressed?
- Resolved by Eoin Clerkin
added 44 commits
-
a5d8cf51...aee5a8b8 - 41 commits from branch
computing:master
- 0d492061 - update Geometry of Rich detector to version v25a
- 5aa0abbc - small changes in coments and creation macro.
- 7ae745e2 - small changes reguested in merge request process.
Toggle commit list-
a5d8cf51...aee5a8b8 - 41 commits from branch
added 13 commits
-
f89bd06d...420f38dc - 9 commits from branch
computing:master
- d37dc821 - update Geometry of Rich detector to version v25a
- 0c369cc8 - small changes in coments and creation macro.
- 3abab66a - small changes reguested in merge request process.
- 8fe2c4b1 - Fix small overlap in shieldingbox.
Toggle commit list-
f89bd06d...420f38dc - 9 commits from branch
- Resolved by Simon Neuhaus
I restarted some jobs, the failure of the last pipeline was linked to something going wrong on the Gitlab runners themselves (end therefore not to the changes done here)
added 12 commits
-
8fe2c4b1...f75d36f3 - 8 commits from branch
computing:master
- c496c26e - update Geometry of Rich detector to version v25a
- f437c9bb - small changes in coments and creation macro.
- dd12aa96 - small changes reguested in merge request process.
- ac55e2df - Fix small overlap in shieldingbox.
Toggle commit list-
8fe2c4b1...f75d36f3 - 8 commits from branch
added 23 commits
-
ac55e2df...e77a8552 - 19 commits from branch
computing:master
- e807e698 - update Geometry of Rich detector to version v25a
- 4bb763a6 - small changes in coments and creation macro.
- 919634ca - small changes reguested in merge request process.
- 9bcdf748 - Fix small overlap in shieldingbox.
Toggle commit list-
ac55e2df...e77a8552 - 19 commits from branch
mentioned in merge request CbmSoft/cbmroot_geometry!299 (merged)
added 6 commits
-
9bcdf748...a25648cd - 2 commits from branch
computing:master
- 4c96c831 - update Geometry of Rich detector to version v25a
- 2dbd3f1a - small changes in coments and creation macro.
- 8e1ff723 - small changes reguested in merge request process.
- cfab40de - Fix small overlap in shieldingbox.
Toggle commit list-
9bcdf748...a25648cd - 2 commits from branch
mentioned in merge request CbmSoft/cbmroot_geometry!304 (merged)
mentioned in merge request CbmSoft/cbmroot_geometry!305 (merged)
@f.uhlig Can you rerun this codeowner check?
I am fine for this to be merged.
assigned to @f.uhlig and unassigned @e.clerkin
- Resolved by Eoin Clerkin
Done. The problem with the pipeline was that the respective runner wasn't enabled for Simon's fork. After enabling it the job was running without problems.