Fix Geant4 configuration

With the additional parameter specialCuts the energy based Geant3 cuts are automatically converted to the range based Geant4 cuts by VMC. Without the parameter the default Geant4 cuts are used. The change reduced the number of secondaries by a factor of 5 or more for a normal CbmRoot UrQMD simulation and speed up the runtime by factors. The runtime compared to Geant3 went from being slower by a factor of 4 to being slower by 30 %. The change of the maximum number of steps from 1e7 to the correct number of 10000 has no effect. There are no tracks exceeding 10000 steps such that there is no additional speedup.

added BugFix Framework Simulation labels

requested review from @v.friese

assigned to @p.-a.loizeau

added 1 commit

• 62eb14b0 - Apply clang format

Compare with previous version

Dear @f.uhlig, @v.friese, @p.-a.loizeau,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

I will test these changes, but to be frank, I am a little surprised by this change makes any difference as I thought it was already exactly the Geant4 configuration which we had already.

I had checked these parameters in sim/transport/gconfig/g4Config.C not sim/transport/steer/CbmGeant4Settings.h** and change you make** is already present, i.e.

line 32

TG4RunConfiguration* runConfiguration = new TG4RunConfiguration("geomGeant4", "QGSP_BERT_EMV", "stepLimiter+specialCuts");

and

line 77

geant4->SetMaxNStep(10000);

I would strongly suggest we remove sim/transport/gconfig/g4Config.C if it does nothing or is overwritten by steer/CbmGeant4Settings.h** as it fooled me.**

requested review from @e.clerkin and removed review request for @v.friese

removed review request for @e.clerkin

requested review from @v.friese

This was tested for beam transport with Trajectories turned on, there was a remarkable saving in terms of run-time for Geant4, which was completely unusable for my task before implementation.

The difference in time per event between Geant3 and Geant4 on 20 events was approximately 10%. However it should be stressed that Geant3 and Geant4 where not giving identical beam trajectories, with many beam ion terminating before the end of the beampipe/cave, thus perhaps giving an unfair time comparison.

@v.friese,

is there an issue why you don't approve the MR?

No. Please attend to the comments by Eoin.

resolved all threads

added 27 commits

• 62eb14b0...966663ab - 25 commits from branch computing:master
• f3b808cf - Fix Geant4 configuration
• 8d79c728 - Apply clang-format

Compare with previous version

@v.friese,

all issues were fixed.

approved this merge request

Not sure what the problem is, but it seems that one of the qa macro fails but only on MacOS
Seems to be a problem that some of the plots changed too much and have now values outside of the Success/Fail cuts, see for example this one under MacOS 11. The expert on this is Sergei who is in holiday currently

added 12 commits

• 8d79c728...a2f409ae - 9 commits from branch computing:master
• 5aa223fe - Fix Geant4 configuration
• bee65801 - Apply clang-format
• 7e5c27e3 - Fix geant4 config script

Compare with previous version

Clang format

requested changes

added 4 commits

• cc21425e - 1 commit from branch computing:master
• e46f2aef - Fix Geant4 configuration
• 0aa071ad - Apply clang-format
• 937fb261 - Fix geant4 config script

Compare with previous version

enabled an automatic merge when all merge checks for 937fb261 pass

@f.uhlig I am not sure why but it seems the problem with the mCBM QA values test under MACOS is still present, but now only for the jobs using Fairsoft apr21

Do you have any idea what could be different between apr21 and nov22 only under MACOS?

aborted the automatic merge because target branch was updated

added 16 commits

• 937fb261...79b61e1d - 13 commits from branch computing:master
• f885bbe3 - Fix Geant4 configuration
• e0263c65 - Apply clang-format
• 84b6396c - Fix geant4 config script

Compare with previous version

added 25 commits

• 84b6396c...4613e86e - 22 commits from branch computing:master
• 88692b35 - Fix Geant4 configuration
• 73b2f727 - Apply clang-format
• 59db4e68 - Fix geant4 config script

Compare with previous version

@s.zharko,

I was able to run the failing test on one of the host. The output file is added here. I am wondering since according to the output of the qa macro the following test fails

[root.exe][14:38:01][INFO] pull_t_station_4 failed mean underflow: -0.493392 < -0.1 - 3.5 x 0.0814191

but when checking the histograms in the output file there is no station 4 of the TOF detector.

Could you please have a look

mcbm_beam_2021_07_surveyed_test.qa.root

added 11 commits

• 59db4e68...4076ef94 - 7 commits from branch computing:master
• d38b06f3 - Fix Geant4 configuration
• ee2219ba - Apply clang-format
• 7f1b63bf - Fix geant4 config script
• 29e955c0 - Workaround for failing qa test on macosx

Compare with previous version

resolved all threads

@p.-a.loizeau,

could you please merge. I would like to port also this one to the jul24_patches branch.

merged