make rich_v24a default

assigned to @p.-a.loizeau

@p.-a.loizeau considering the nearest to the End of Year and the simpleness of the change, it would be good to merge this as soon as possible. Only change is to update the geometry hash.

Mon 16th inst. @c.pauly in an email to @e.clerkin, @s.neuhaus and @c.hoehne that the RICH team desires that this rich geometry rich_v24a be made default. This MR fulfills this request.

Overlaps tests failed. This will need to be investigated locally before proceeding.

@s.neuhaus, @ma.beyer you said that you already extensively use the rich_v24a geometry within the RICH team?

@e.clerkin It seems that these new overlap are of the type extrusion, not mentioned in the original geometry MR or in the redmine issues
=> They amount to around 50 overlaps in total
=> from the names, they seem to be internal, so I am unsure as to why they were not detected during the geometry check... maybe we we need to recheck once more that we apply the same settings to the geometry and setup overlap checks (-_-)
=> I will try to both test locally and recheck on run4 (probably need 1-2 hours as I need to compile a fresh copy to make sure nothing interferes) => Only if confirmed these are real: it should be decided whether they are all added to the ignore/expected list or whether this should be fixed

Examples:

Unexpected Overlap:
 = Overlap ov00000: mirror_support_pillar extruded by: mirror_support_pillar/Studs_Half_1/Stud_1/Studs_1
                                                                                        |------|---------> Multiple ones with [1,3]

Unexpected Overlap:
 = Overlap ov00006: rich_gas extruded by: rich_gas/mainframe_1/mainframe1_3
                                                                        |-|---------> Multiple ones with [1,7]

Unexpected Overlap:
 = Overlap ov00022: rich_gas extruded by: rich_gas/rich_exit_1 ovlp=1.5

Unexpected Overlap:
 = Overlap ov00023: mainframe5 extruded by: mainframe5/mainframe5_gas_1 ovlp=0.649328

Unexpected Overlap:
 = Overlap ov00046: rich_cont extruded by: rich_cont/rich_pipe_1 ovlp=0.25

Unexpected Overlap:
 = Overlap ov00047: Studs extruded by: Studs/StudsGas_1 ovlp=0.0449394

Unexpected Overlap:
 = Overlap ov00048: PillarConnection extruded by: PillarConnection/PillarConnectionGas_1 ovlp=0.0295619

Two other seem to be "standard overlaps":

Unexpected Overlap:
 = Overlap ov00052: rich_gas/mainframe_1/mainframe1_2 overlapping rich_gas/rich_entrance_1 ovlp=2.5

Unexpected Overlap:
 = Overlap ov00053: rich_gas/mainframe_1/mainframe1_1 overlapping rich_gas/rich_entrance_1 ovlp=2.5

There is in addition one expected overlap not being properly ignored for the 2 stations MVD due to the volume change name in the cfv setup, I will add a commit fixing this to the MR

These are quite serious large overlaps which would prevent rich_v24a being default, if they are truly there.

We have a redmine page made 11 months ago with some outstanding issues on the rich_v24a geometry https://redmine.cbm.gsi.de/issues/3139

In it, we list 3 overlaps, but these overlaps were extremely small and were this not of concern. I would have done an overlap check on the geometry a year ago, and it doesn't make a lot of sense that suddenly there are such a large number of overlaps now.

Also note all overlaps are internal to the rich.

@s.neuhaus Can you comment here, do you remember something different from me?

Hi, I remember as well that there was overlap check approximate a year ago where only small already in previous geometry version existing overlaps was founded. At least some of the now founded extrusion overlaps are that some of the gas volumes which are added to cut away the inner part of the upper volume which is implemented as massive but shouldn't be. I think this extrusions doesn't matter.

Hi @s.neuhaus,

After resolving my login issues, I was able to also execute the overlaps checker macro, and I can confirm @p.-a.loizeau report. Amazingly there are 52 reported unexpected overlaps, many of them large.

Check overlaps:      [==========]  579265 [100.00 %]           52                                                                                                                                           
Info in : Number of illegal overlaps/extrusions : 54                                                                                                                         
Overlap ov00000: mirror_support_pillar extruded by: mirror_support_pillar/Studs_Half_1/Stud_1/Studs_1 ovlp=32.2255                                                                                       
Overlap ov00001: mirror_support_pillar extruded by: mirror_support_pillar/Studs_Half_2/Stud_1/Studs_1 ovlp=32.2255                                                                                       
Overlap ov00002: mirror_support_pillar extruded by: mirror_support_pillar/Studs_Half_2/Stud_2/Studs_1 ovlp=16.2704                                                                                       
Overlap ov00003: mirror_support_pillar extruded by: mirror_support_pillar/Studs_Half_1/Stud_2/Studs_1 ovlp=16.2704                                                                                       
Overlap ov00004: mirror_support_pillar extruded by: mirror_support_pillar/Studs_Half_2/Stud_3/Studs_1 ovlp=6.4145                                                                                        
Overlap ov00005: mirror_support_pillar extruded by: mirror_support_pillar/Studs_Half_1/Stud_3/Studs_1 ovlp=6.4145                                                                                        
Overlap ov00006: rich_gas extruded by: rich_gas/mainframe_1/mainframe1_3 ovlp=6.275                                                                                                                      
Overlap ov00007: rich_gas extruded by: rich_gas/mainframe_1/mainframe4_1 ovlp=6.275                                                                                                                      
Overlap ov00008: rich_gas extruded by: rich_gas/mainframe_1/mainframe1_5 ovlp=6.275                                                                                                                      
Overlap ov00009: rich_gas extruded by: rich_gas/mainframe_1/mainframe4_2 ovlp=6.275                                                                                                                      
Overlap ov00010: rich_gas extruded by: rich_gas/mainframe_1/mainframe7_1 ovlp=3                                                                                                                          
Overlap ov00011: rich_gas extruded by: rich_gas/mainframe_1/mainframe5_4 ovlp=3                                                                                                                          
Overlap ov00012: rich_gas extruded by: rich_gas/mainframe_1/mainframe7_2 ovlp=3                                                                                                                          
Overlap ov00013: rich_gas extruded by: rich_gas/mainframe_1/mainframe1_2 ovlp=3                                                                                                                          
Overlap ov00014: rich_gas extruded by: rich_gas/mainframe_1/mainframe1_1 ovlp=3                                                                                                                          
Overlap ov00015: rich_gas extruded by: rich_gas/mainframe_1/mainframe7_3 ovlp=3
Overlap ov00016: rich_gas extruded by: rich_gas/mainframe_1/mainframe7_4 ovlp=3                                                                                                                          
Overlap ov00017: rich_gas extruded by: rich_gas/mainframe_1/mainframe5_1 ovlp=3                                                                                                                          
Overlap ov00018: rich_gas extruded by: rich_gas/mainframe_1/mainframe5_2 ovlp=3                                                                                                                          
Overlap ov00019: rich_gas extruded by: rich_gas/mainframe_1/mainframe5_3 ovlp=3                                                                                                                          
Overlap ov00020: mirror_support_pillar extruded by: mirror_support_pillar/Studs_Half_1/Stud_4/Studs_1 ovlp=2.94363                                                                                       
Overlap ov00021: mirror_support_pillar extruded by: mirror_support_pillar/Studs_Half_2/Stud_4/Studs_1 ovlp=2.94363                                                                                       
Overlap ov00022: rich_gas extruded by: rich_gas/rich_exit_1 ovlp=1.5                                                                                                                                     
Overlap ov00023: mainframe5 extruded by: mainframe5/mainframe5_gas_1 ovlp=0.649328                                                                                                                       
Overlap ov00024: rich_gas extruded by: rich_gas/mainframe_1/mainframe2_5 ovlp=0.5                                                                                                                        
Overlap ov00025: rich_gas extruded by: rich_gas/mainframe_1/mainframe6_15 ovlp=0.5                                                                                                                       
Overlap ov00026: rich_gas extruded by: rich_gas/mainframe_1/mainframe6_16 ovlp=0.5                                                                                                                       
Overlap ov00027: rich_gas extruded by: rich_gas/mainframe_1/mainframe6_17 ovlp=0.5                                                                                                                       
Overlap ov00028: rich_gas extruded by: rich_gas/mainframe_1/mainframe6_18 ovlp=0.5                                                                                                                       
Overlap ov00029: rich_gas extruded by: rich_gas/mainframe_1/mainframe6_14 ovlp=0.5                                                                                                                       
Overlap ov00030: rich_gas extruded by: rich_gas/mainframe_1/mainframe6_13 ovlp=0.5   
Overlap ov00031: rich_gas extruded by: rich_gas/mainframe_1/mainframe6_12 ovlp=0.5                                                                                                                       
Overlap ov00032: rich_gas extruded by: rich_gas/mainframe_1/mainframe6_11 ovlp=0.5                                                                                                                       
Overlap ov00033: rich_gas extruded by: rich_gas/mainframe_1/mainframe8_1 ovlp=0.5                                                                                                                        
Overlap ov00034: rich_gas extruded by: rich_gas/mainframe_1/mainframe8_2 ovlp=0.5                                                                                                                        
Overlap ov00035: rich_gas extruded by: rich_gas/mainframe_1/mainframe8_3 ovlp=0.5                                                                                                                        
Overlap ov00036: rich_gas extruded by: rich_gas/mainframe_1/mainframe8_4 ovlp=0.5                                                                                                                        
Overlap ov00037: rich_gas extruded by: rich_gas/mainframe_1/mainframe4_4 ovlp=0.5                                                                                                                        
Overlap ov00038: rich_gas extruded by: rich_gas/mainframe_1/mainframe4_3 ovlp=0.5                                                                                                                        
Overlap ov00039: rich_gas extruded by: rich_gas/mainframe_1/mainframe3_8 ovlp=0.5                                                                                                                        
Overlap ov00040: rich_gas extruded by: rich_gas/mainframe_1/mainframe3_5 ovlp=0.5                                                                                                                        
Overlap ov00041: rich_gas extruded by: rich_gas/mainframe_1/mainframe3_4 ovlp=0.5                                                                                                                        
Overlap ov00042: rich_gas extruded by: rich_gas/mainframe_1/mainframe3_1 ovlp=0.5                                                                                                                        
Overlap ov00043: rich_gas extruded by: rich_gas/mainframe_1/mainframe2_8 ovlp=0.5                                                                                                                        
Overlap ov00044: rich_gas extruded by: rich_gas/mainframe_1/mainframe2_7 ovlp=0.5                                                                                                                        
Overlap ov00045: rich_gas extruded by: rich_gas/mainframe_1/mainframe2_6 ovlp=0.5                                                                                                                        
Overlap ov00046: rich_cont extruded by: rich_cont/rich_pipe_1 ovlp=0.25                                                                                                                                  
Overlap ov00047: Studs extruded by: Studs/StudsGas_1 ovlp=0.0449394                                                                                                                                      
Overlap ov00048: PillarConnection extruded by: PillarConnection/PillarConnectionGas_1 ovlp=0.0295619 
Overlap ov00049: Studs extruded by: Studs/StudsGas_1 ovlp=0.0284856                                                                                                                                      
Overlap ov00050: Studs extruded by: Studs/StudsGas_1 ovlp=0.0135205                                                                                                                                      
Overlap ov00051: Studs extruded by: Studs/StudsGas_1 ovlp=0.000872687                                                                                                                                    
Overlap ov00052: rich_gas/mainframe_1/mainframe1_2 overlapping rich_gas/rich_entrance_1 ovlp=2.5                                                                                                         
Overlap ov00053: rich_gas/mainframe_1/mainframe1_1 overlapping rich_gas/rich_entrance_1 ovlp=2.5

Does anyone have any suggestions, how this can be the case? Or how this could have been missed?

Also could reproduce it locally on Ubuntu 22.04.

@e.clerkin Should I make the fix for the MVD expected overlap in a separate MR?
I confirmed locally that a single line update can fix this

I see you have already done this in MR -!1987 (merged)

Yes, this way whatever is reported here in the future tests will be really only concerning RICH

I now managed to make a macro to check the overlaps inside the geometry file of a single detector check_overlaps_single_det.C.
It is called the following way:

root -l -q 'check_overlaps_single_det.C("../../geometry/rich/rich_v24a")'

Not sure if it matches the tools that @e.clerkin already has on his side.

Interestingly, with this macro only the extrusions are found, and not the overlaps of the mainframe in the rich_gas branch

As these issues do block the rich_v24a becoming default and before someone pull the latest instance of the geometry repo to the one with this geometry as a default, I will revert the changes to the setup files.

This is done in MR-CbmSoft/cbmroot_geometry!280 (merged)