Skip to content
Snippets Groups Projects

Add more time offsets to parameters of online unpackers for BMon and TOF

All threads resolved!
  • Fix bug due to unsigned integer used for offset storage (OK until now, would have been a problem if negative offsets used!)
  • Add possibility to set the BMon system time offset from YAML file
  • Add possibility to set the TOF system time offset from YAML file
  • Add possibility to set TOF "per CROB" time offsets from YAML file

Set as Draft until a corresponding MR to the parameter repository is prepared and merged (to ensure that the code change is transparent in terms of unpacker output)

Probably of interest to: @n.herrmann @d.gutierrezmenendez @a.bercuci @a.toia

Edited by Pierre-Alain Loizeau

Merge request reports

Merge request pipeline #31857 passed

Merge request pipeline passed for 1ee806c4

Merged by Pierre-Alain LoizeauPierre-Alain Loizeau 9 months ago (Nov 19, 2024 3:25pm UTC)

Loading

Pipeline #31859 passed

Pipeline passed for 1ee806c4 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 2 commits

    • 10ca40ea - Unify name of time offset getters in online BMon/STS/TOF unpackers w/ TRD ones
    • 91041362 - Cosmetics: rename CROB Nb getter in BMon/TOF online unpackers

    Compare with previous version

  • added 1 commit

    • e648d752 - Bump parameters repo hash to bring matching online pars

    Compare with previous version

  • Pierre-Alain Loizeau marked this merge request as ready

    marked this merge request as ready

  • Pierre-Alain Loizeau changed the description

    changed the description

  • Remove draft state now that the corresponding parameters are merged and that it is verified this MR does not change the unpacking output

  • Missed one extra TOF parameter YAML file. Will do a second parameters MR now.

  • added 1 commit

    • 1ee806c4 - Bump parameters repo hash to bring matching online pars

    Compare with previous version

  • Dear @d.smith, @fweig, @v.friese, @n.herrmann, @i.deppner, @f.uhlig,

    you have been identified as code owner of at least one file which was changed with this merge request.

    Please check the changes and approve them or request changes.

  • Pierre-Alain Loizeau resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading