Correct ADC to electrons
fix sts/#6
- Change 'AdcToCharge' implementation.
- Change 'ChargeToAdc' implementation.
- Drop ADC values below 1 in digitization.
Edit: issue ref.
Merge request reports
Activity
added Reconstruction label
requested review from @v.friese
assigned to @v.friese
- Resolved by David Gutiérrez Menéndez
@d.gutierrezmenendez The failing formatting errors are only alignment of comments offsets between consecutive lines, happening in part of the code which you did not touch. Probably means that nobody modified these files since we introduced the first version of our clang-format settings (we apply new settings only incrementally whenever a file is newly modified).
I think it is safe to either apply by hand the proposals from the CDASH report or use the
./scripts/check-apply-format-changes.sh apply
described in this Redmine wiki page
- Resolved by David Gutiérrez Menéndez
Got it!!
On a separate note, I dont have access to cbmroot redmine project.
added 8 commits
- 761e7865 - KF: adding the material budget maps cacheing option to the KF-setup builder class
- 4a49dd7d - CA: separation of detector usage flags into the in-geometry and is-active
- fed85937 - run_analysis_tree_maker.C: adding the setup tag to the CbmSetup instance
- 7665f37f - Addinga hash getter for a CbmSetup; storing and testing a reference hash in...
- 501db27e - bugfix: addition of material budget map
- 7c448a83 - bugfix: kf::MaterialMap::Add() function
- 2850cf55 - comments/warning printouts clean-up
- 9e105d20 - kf: removing GetThickness(int) and GetThickness(int, int) functions from the kf::MaterialMap class
Toggle commit listadded 10 commits
-
9e105d20...75737e77 - 8 commits from branch
computing:master
- 5a465ff0 - Correct ADC to electrons
- cc172f11 - Apply clang-format
-
9e105d20...75737e77 - 8 commits from branch
@p.-a.loizeau this MR also affects simulation, it changes the Charge to ADC conversion that is used during digitization to be consistent with data. Maybe throw that label too
Dear @v.friese,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
added Simulation label
added 2 commits
added 13 commits
-
45c92d96...ccfc5b0f - 12 commits from branch
computing:master
- f51dde48 - Merge branch cbmroot:master into bugfix/6-adc-to-charge
-
45c92d96...ccfc5b0f - 12 commits from branch
added 2 commits
- Resolved by David Gutiérrez Menéndez