Bugfix: cleanup dependency of AlgoOffline on fles_logging

1. AlgoOffline already depends on FairLogger 3 lines above, not sure about the outcome, it may explain some of the build warnings and the lower than I expected reduction in the weekly builds log size
2. There were multiple instances in the algo library were the fles_logging header log.hpp was used instead of the compatibility one, with sometimes a mix in the same folder
3. The NO_ROOT flag was propagated to multiple higher level reco library (steer, offline steer, probably also analysis ones...) through Littrack which was depending on Littrackparallel which itself was wrongly depending on the online KfCore instead of KfCoreOffline. This combined with the includes in the Digi classes to force a dependency on fles_logging in offline libraries which should have only depended on FairLogger

Difference between the last two versions shows how involved the debugging process was (around 10 hours on my side)

Redmine: Refs #3399

added BugFix Build System Online labels

requested review from @f.uhlig

assigned to @f.uhlig

added 1 commit

• af3b1233 - Bugfix: in algo, replace all occurences of log.hpp includes with the FairLogger compat header

Compare with previous version

changed title from Bugfix: remove wrong dependency of AlgoOffline on fles_logging to Bugfix: cleanup dependency of AlgoOffline on fles_logging

changed the description

added 1 commit

• 89ba084d - Bugfix: in algo, replace all occurences of log.hpp includes with the FairLogger compat header

Compare with previous version

added 1 commit

• b57bc0d2 - Bugfix: in algo, replace all occurences of log.hpp includes with the FairLogger compat header

Compare with previous version

added 1 commit

• 1fd904ef - Bugfix: in algo, replace all occurences of log.hpp includes with the FairLogger compat header

Compare with previous version

marked this merge request as draft

added 5 commits

• 2283fab9 - 1 commit from branch computing:master
• 068699ad - Cleanup usage of cout in trd algo HitFinding
• 2150a774 - In algo TRD HitFactory2D, fix wrong class header include + related missing header
• 6755a9b7 - Bugfix: in algo, replace all occurences of log.hpp includes with the FairLogger compat header
• 9043a55e - Bugfix: remove wrong dependency of AlgoOffline on fles_logging

Compare with previous version

resolved all threads

added 2 commits

• 292d9929 - Bugfix: in algo, replace all occurences of log.hpp includes with the FairLogger compat header
• a09096a1 - Bugfix: remove wrong dependency of AlgoOffline on fles_logging

Compare with previous version

added 1 commit

• 3cf87ce8 - Logger Bugfix: Fix wrong lib dependency in // littrack + resulting missing dependencies

Compare with previous version

@f.uhlig I finally nailed it, but it was a nightmare to follow these dependencies: the NO_ROOT flag was propagated through the Littrackparallel library to half of the high level reco libraries (steer, analysis, offline reco binaries...), leading to the wrong logger being included when the corresponding header file was coming through the digi classes headers (especially the STS ones)... So two separate things coming together to create an error 2 or 3 levels beyond where they happened

I pushed the commit with all the pre-processor warnings in to have an example online that I can show to convince people why we have to be careful with pre-processor flags and why we really need to resolve this conflicting loggers stuff.
I will clean it out and remove the draft mode once I see at least one pipeline going through for all runners, at this stage I still half-expect some new compilation problems on some of them

Dear @d.smith, @fweig, @v.friese, @v.singhal, @ma.beyer, @n.herrmann, @i.deppner, @a.bercuci, @p.kaehler, @f.uhlig, @p.-a.loizeau, @se.gorbunov, @s.zharko,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

added 6 commits

• da5766a6 - Add git rebase original file backups to main gitignore
• 2086f279 - Cleanup usage of cout in trd algo HitFinding
• 95b1b2eb - In algo TRD HitFactory2D, fix wrong class header include + related missing header
• f0552270 - Bugfix: in algo, replace all occurences of log.hpp includes with the FairLogger compat header
• c05a48e6 - Logger Bugfix: Fix wrong lib dependency in // littrack + resulting missing dependencies
• 2438bcd5 - Bugfix: remove wrong dependency of AlgoOffline on fles_logging

Compare with previous version

resolved all threads

marked this merge request as ready

changed the description

approved this merge request

merged

changed the description