Adding KF-setup to the ca::Parameters
The MR introduces KF-setup instances to the ca::Parameters object: fGeometrySetup contains all the tracking stations, provided by the tracking detector interfaces, and fActiveSetup is created on the flight and contains only active tracking stations.
Also:
- index mapping of a geo layer to the (detector, id) is introduced
- mechanism of layer disabling is introduced to the kf::Setup
- old material maps in the CA are replaced with the new ones from the fActiveSetup
NOTE The new maps have 100 bins in one axis and cover full tracking acceptance (to be tested)
Todo:
-
provide kf::Setup initialization in QA-tasks -
provide kf::Setup initialization in the online binary (from files) -
replace the subsystem selection for different tracking modes from the CbmL1::Init() to corresponding YAML configs (the geometry setup will include all the subsystems among MVD, STS, MuCh, TRD, TOF, if ones are presented in the geometry and provide hits; for a particular tracking mode unused setups are to be disabled in the config)
Update 14.10.2024
The timeout for mcbm_2024_rec_3105 was temporarily increased from 70 to 95 seconds. This is needed to keep two setup initialization schemes (the old one in the CA and the new one in the KF). The both initialization schemes execute material budget map generation for different tracking stations, which is time-consuming. The old geometry initialization scheme will be removed after the full migration of the track fitting utilities from CA to the KF library. The table below show timings, which were measured in the mcbm_2024_rec_3105 test for the master (d89a5a0f) and the KF-setup-init (this MR) branches.
| time measurement | master, [s] | !1931 (merged), [s] |
|---|---|---|
| CbmL1::Init() | 33.22 | 58.51 |
| CA algorithm exec. | 1.206 | 1.176 |
| FairMonitor tot. | 3.017 | 2.974 |
| macro runtime | 40.72 | 66.27 |
| test runtime | 61.52 | 89.00 |
Merge request reports
Activity
requested review from @se.gorbunov
assigned to @se.gorbunov
added 10 commits
-
fa1f22d3 - 1 commit from branch
computing:master - 7ce86ced - Index map for kf-setup
- 31c370dc - KF-setup initialization improvement
- 53405cc7 - KF: module disabling mechanism in the kf::Setup
- eee8f4ef - Add setup initialization to CA
- c3d05e65 - KF: bugfix in KF-setup layer disabling; TrackingSetupBuilder is a singleton
- f47fa9fc - CA: replacement of old material maps with the new ones
- 2d3b2d06 - KF:
- 13a45e11 - CbmEnumArray.h
- 1a8bb515 - CA: reading KF geo-setup in related QA-tasks and the online binary
Toggle commit list-
fa1f22d3 - 1 commit from branch
added 1 commit
- bab10b41 - CA: replaced the TrackingSetupBuilder class from KfCbm to L1; disable...
added 1 commit
- f8e9984d - CA: replacing the hard-coded disabling of detector subsystems with respect to...
marked the checklist item replace the subsystem selection for different tracking modes from the CbmL1::Init() to corresponding YAML configs (the geometry setup will include all the subsystems among MVD, STS, MuCh, TRD, TOF, if ones are presented in the geometry and provide hits; for a particular tracking mode unused setups are to be disabled in the config) as completed
added 13 commits
-
4b2696e9 - 1 commit from branch
computing:master - 4b2696e9...f7825248 - 2 earlier commits
- e99d4d3d - KF: module disabling mechanism in the kf::Setup
- fa8d51d8 - Add setup initialization to CA
- 0acdb842 - KF: bugfix in KF-setup layer disabling; TrackingSetupBuilder is a singleton
- 271adbfa - CA: replacement of old material maps with the new ones
- d104c64f - KF:
- ac3a409b - CbmEnumArray.h
- 571f3aa1 - CA: reading KF geo-setup in related QA-tasks and the online binary
- ab7f1182 - CA: replaced the TrackingSetupBuilder class from KfCbm to L1; disable...
- 345f4ca5 - CA: replacing the hard-coded disabling of detector subsystems with respect to...
- 272e5883 - CA-QA: adding the Setup QA task for full-CBM, adding material maps histograms to the Setup QA task
Toggle commit list-
4b2696e9 - 1 commit from branch
added 1 commit
- 676bd414 - KF[bugfix]: accessing the material thickness by bin indices in the kf::MaterialMap
added 14 commits
-
7d7b1a1d - 1 commit from branch
computing:master - 7d7b1a1d...208ce581 - 3 earlier commits
- ae9fcadb - Add setup initialization to CA
- 2a1e05fc - KF: bugfix in KF-setup layer disabling; TrackingSetupBuilder is a singleton
- 3bfa2786 - CA: replacement of old material maps with the new ones
- 67a45c3b - KF:
- 05680aa2 - CbmEnumArray.h
- 4203d0b6 - CA: reading KF geo-setup in related QA-tasks and the online binary
- 514e1bff - CA: replaced the TrackingSetupBuilder class from KfCbm to L1; disable...
- 4eea203c - CA: replacing the hard-coded disabling of detector subsystems with respect to...
- a478ae4d - CA-QA: adding the Setup QA task for full-CBM, adding material maps histograms to the Setup QA task
- 3ac020f6 - KF[bugfix]: accessing the material thickness by bin indices in the kf::MaterialMap
Toggle commit list-
7d7b1a1d - 1 commit from branch
mentioned in merge request CbmSoft/cbmroot_parameter!201 (merged)
added 18 commits
-
aa98247b...712d0b65 - 2 commits from branch
computing:master - 712d0b65...498c65f5 - 6 earlier commits
- 982a5cc6 - KF:
- 1481a1d1 - CbmEnumArray.h
- b044f374 - CA: reading KF geo-setup in related QA-tasks and the online binary
- 9dd156da - CA: replaced the TrackingSetupBuilder class from KfCbm to L1; disable...
- a291a5cf - CA: replacing the hard-coded disabling of detector subsystems with respect to...
- 1a75a99c - CA-QA: adding the Setup QA task for full-CBM, adding material maps histograms to the Setup QA task
- becf57eb - KF[bugfix]: accessing the material thickness by bin indices in the kf::MaterialMap
- 1b0b9f5d - QA-Checker: cosmetics
- ebd749b3 - QA: cosmetics
- 6d178bf4 - Parameter repository hash update
Toggle commit list-
aa98247b...712d0b65 - 2 commits from branch
added 1 commit
- 7fcb124c - Add delay before the log-check for the mcbm2024 CI-test
added 26 commits
-
7fcb124c...d89a5a0f - 9 commits from branch
computing:master - d89a5a0f...ca01620b - 7 earlier commits
- fb1b4379 - CbmEnumArray.h
- 45651dc3 - CA: reading KF geo-setup in related QA-tasks and the online binary
- 830cf40a - CA: replaced the TrackingSetupBuilder class from KfCbm to L1; disable...
- 45511adf - CA: replacing the hard-coded disabling of detector subsystems with respect to...
- 97f0f032 - CA-QA: adding the Setup QA task for full-CBM, adding material maps histograms to the Setup QA task
- a6dd27d0 - KF[bugfix]: accessing the material thickness by bin indices in the kf::MaterialMap
- 20d965ea - QA-Checker: cosmetics
- 2e91861c - QA: cosmetics
- df1abd74 - Parameter repository hash update
- 943cfb74 - Timeout for mcbm_2024_rec_3105 is temporarily increased to 95s
Toggle commit list-
7fcb124c...d89a5a0f - 9 commits from branch
added 1 commit
- 3a6f3591 - Timeout for mcbm_2024_rec_3105 is temporarily increased to 95s, timeout for...
added 1 commit
- 05321441 - Timeout for mcbm_2024_rec_3105 is temporarily increased to 95s, timeout for...
Dear @d.smith, @fweig, @f.uhlig, @v.friese, @p.-a.loizeau, @se.gorbunov, @s.zharko,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
mentioned in merge request !1869 (merged)