bugfix: adding original field for all FieldRegion<T> specializations
In the merge request, an original magnetic field function is set for all possible specializations of the FieldRegion class. This removes an assertion call in the CbmRecoQaTask task execution (the mcbm_2024_qa_3105 test), which was reported by @a.bercuci.
Merge request reports
Activity
requested review from @se.gorbunov
assigned to @se.gorbunov
added 1 commit
- 145084dc - bugfix: adding original field for all FieldRegion<T> specializations
Dear @se.gorbunov, @s.zharko,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
The changes are fixing the issue. Thank you very much for your fast reaction. @p.-a.loizeau I wonder though why this was not seen during the tests ?
Not sure.
I could reproduce the crash in local
ctest -R <test_name>
runs onrun4
, but I do not see it in either the CI pipelines of the last days (especially !1904 (merged) which I think introduced the problem) nor in the Nightly tests.
As this is linked to templates instantiation, it could be that when running in CDASH mode something extra is done with the libraries which loads the class specialization in the background, which is not present when running only ctest or only part of all the testsMaybe @f.uhlig has some idea on what was happening here.