Skip to content
Snippets Groups Projects

replacing isnan/isfinite by std::isnan/std::isfinite

Merged Axel Puntke requested to merge apuntke/cbmroot:isnanpatch into master

Here I replaced isnan and isfinite function calls by std::isnan and std::isfinite, because it is not guarannteed by the C++ standard that the compiler brings these functions to the global namespace when including the c++ header (see https://stackoverflow.com/questions/18128899/is-isnan-in-the-std-namespace-more-in-general-when-is-std-necessary-optio).

I faced some compile issues with this today. I think this changes should not affect the functionality.

Merge request reports

Merge request pipeline #30708 failed

Merge request pipeline failed for 188dc1ce

Merged by Sergey GorbunovSergey Gorbunov 10 months ago (Aug 5, 2024 3:41pm UTC)

Loading

Pipeline #30710 passed

Pipeline passed for 188dc1ce on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading