Cleanup of tracking core.
Cleaned up the core tracking classes. Summary of changes:
- Removed access to ca::Framework from ca::TrackExtender, ca::TrackFitter, ca::TripletConstructor, ca::CloneMerger, ca::TrackFinder and ca::TrackFinderWindow.
- Simplified the interfaces of these classes.
- General instruction-wise cleanup of these classes (applied std functions in some places etc.). In particular, streamlining of ca::TrackFinder.
- Made debugging functions in ca::Framework static.
- Moved TrackingMode enum from CaFramework.h to CaParameters.h (needed to avoid cyclic header file dependency).
- Moved some magnetic-field dependent variables to ca::TripletConstructor (they are only used there).
- Restricted the scope of many variables, i.e. turned class-fields into local variables in many instances (e.g. fvMonitorDataThread, fvTrackFinderWindow, fTrackingMode, fvWData, fvWindowStartThread, fvWindowEndThread, fvStatNwindows, fvStatNhitsProcessed, fvHitFirstTriplet and fvHitNofTriplets).
- Eliminated the Init() functions of some classes. Moved initialization to the constructors.
- Improved distinction between class-parameters and working data. Class parameters are passed to constructor, working data is passed as arguments to function calls.
Update: Absorbed !1891 (closed).
Edited by Dominik Smith
Merge request reports
Activity
Filter activity
requested review from @s.zharko
assigned to @se.gorbunov
mentioned in merge request !1885 (closed)
added 1 commit
- f91055bc - Cleaned up the core tracking classes. Summary of changes:
Dear @d.smith, @fweig, @se.gorbunov, @s.zharko,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
mentioned in merge request !1882 (closed)
- Resolved by Dominik Smith
mentioned in merge request !1891 (closed)
added 1 commit
- b68ebc23 - Cleaned up the core tracking classes. Summary of changes:
added 1 commit
- e2db6999 - Cleaned up the core tracking classes. Summary of changes:
added 1 commit
- 998891da - Cleaned up the core tracking classes. Summary of changes:
Please register or sign in to reply