JSON approach: improved log + new default settings
Slight improvements to the readability of log output from bash scripts and new default settings in config.json.
Merge request reports
Activity
changed milestone to %OCT23
added Framework Simulation labels
assigned to @f.uhlig
- Resolved by Florian Uhlig
@f.uhlig Hi Florian, I hope this MR can still be included in the OCT23 RC. Changes are only of cosmetics nature and I updated some of the default settings in config.json to make it work out of the box. One important change is not included, that is to update the cbmroot version in config.json. Would it be possible to put the release itself there, which would only work if I know the exact location of the installation before you install it?
Dear @f.uhlig, @p.-a.loizeau,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
enabled an automatic merge when the pipeline for 47f986f2 succeeds
added Ported label
This config.json is just an example which is aimed to be usable out of the box for new users and hence default settings should be in a reasonable range, but the exact number you're using for productions is up to the user and particular case.
Concerning the PWG common, the old value of 1e3 is just to make productions comparable to event-by-event simulations as for the low event rate, events are well separated in time and one can compare performance between the different digitization modes.
So whether you need to recompute something or not depends on what you aim to study. The default parameters should be in a realistic range in comparison to the experimental data to be collected, but should not be taken blindly.