[mCBM] Digi filter around spill start in legacy unpacker
See commits
Draft mode until following fixed
-
Hard-coded path to accelerator event files (probably enough if hardcoded to somewhere in production
) => Changed to point the final location onlustre
-
Options values: filter window limits, ...
=> Need setters -
Testing by main detector users (STS, TRD, MUCH, ...) + effect on event building & tracking
=> Will probably never happen, but changes not expected to interfere with original mode of operation => Tested locally by me, only the few runs of June 2024 may see a change, few users should ever see a difference
Merge request reports
Activity
added Reconstruction mCBM labels
added 5 commits
- 35ed69a4 - Add KickerStart (fast extr.) to SIS18 Raw AccData interface class
- 8798fdff - Add optional digi filter around Spill Start/Stop to legacy unpacking
- d21bce40 - Add actual spill filtering + sanitize monitor histos generation and saving
- a922e74a - [mCBM 2024] add unpack params for mMUCH in June 2024 Ur beamtime
- bce2d682 - TEMP DO NOT MERGE: add usage of spill start filter in legacy unpack macro
Toggle commit listDear @p.-a.loizeau, @f.uhlig, @v.friese,
you have been identified as code owner of at least one file which was changed with this merge request.
Please check the changes and approve them or request changes.
added CodeOwners label
added 78 commits
-
bce2d682...94040dab - 73 commits from branch
computing:master
- 4c4736d2 - Add KickerStart (fast extr.) to SIS18 Raw AccData interface class
- a5ad19a5 - Add optional digi filter around Spill Start/Stop to legacy unpacking
- 1010b00e - Add actual spill filtering + sanitize monitor histos generation and saving
- 529235c4 - [mCBM 2024] add unpack params for mMUCH in June 2024 Ur beamtime
- 384cd07b - TEMP DO NOT MERGE: add usage of spill start filter in legacy unpack macro
Toggle commit list-
bce2d682...94040dab - 73 commits from branch
added 12 commits
-
384cd07b...82ab656f - 7 commits from branch
computing:master
- 40cf173e - Add KickerStart (fast extr.) to SIS18 Raw AccData interface class
- b57d5c9b - Add optional digi filter around Spill Start/Stop to legacy unpacking
- 85be52b8 - Add actual spill filtering + sanitize monitor histos generation and saving
- d3b6eb50 - [mCBM 2024] add unpack params for mMUCH in June 2024 Ur beamtime
- ddd7f890 - TEMP DO NOT MERGE: add usage of spill start filter in legacy unpack macro
Toggle commit list-
384cd07b...82ab656f - 7 commits from branch
added 6 commits
- 026ea7f4 - Add KickerStart (fast extr.) to SIS18 Raw AccData interface class
- 879c0701 - Add optional digi filter around Spill Start/Stop to legacy unpacking
- 1a78ddda - Add actual spill filtering + sanitize monitor histos generation and saving
- 34b13a96 - [mCBM 2024] add unpack params for mMUCH in June 2024 Ur beamtime
- ea8cd797 - TEMP DO NOT MERGE: add usage of spill start filter in legacy unpack macro
- 769b3bb5 - TEMP: enable TRD2D in run unpack tsa
Toggle commit listadded 116 commits
-
769b3bb5...471ec40f - 110 commits from branch
computing:master
- 1b2a6285 - Add KickerStart (fast extr.) to SIS18 Raw AccData interface class
- 2bc533f7 - Add optional digi filter around Spill Start/Stop to legacy unpacking
- 93506c63 - Add actual spill filtering + sanitize monitor histos generation and saving
- 0c4fc5b4 - [mCBM 2024] add unpack params for mMUCH in June 2024 Ur beamtime
- 130886e4 - TEMP DO NOT MERGE: add usage of spill start filter in legacy unpack macro
- b7570547 - TEMP: enable TRD2D in run unpack tsa
Toggle commit list-
769b3bb5...471ec40f - 110 commits from branch
added 4 commits
Toggle commit listadded 52 commits
-
e3cb31c5...bf068f78 - 46 commits from branch
computing:master
- 190f1089 - Add KickerStart (fast extr.) to SIS18 Raw AccData interface class
- 38a7068a - Add optional digi filter around Spill Start/Stop to legacy unpacking
- 2cc9a703 - Add actual spill filtering + sanitize monitor histos generation and saving
- e2fa5a2e - [mCBM 2024] add unpack params for mMUCH in June 2024 Ur beamtime
- 2b5f7178 - TEMP DO NOT MERGE: add usage of spill start filter in legacy unpack macro
- 4b9dceb3 - TEMP: enable TRD2D in run unpack tsa
Toggle commit list-
e3cb31c5...bf068f78 - 46 commits from branch
added 24 commits
-
4b9dceb3...86ff1308 - 18 commits from branch
computing:master
- 09093110 - Add KickerStart (fast extr.) to SIS18 Raw AccData interface class
- 39bb2f68 - Add optional digi filter around Spill Start/Stop to legacy unpacking
- b0138fc4 - Add actual spill filtering + sanitize monitor histos generation and saving
- 15f828f4 - [mCBM 2024] add unpack params for mMUCH in June 2024 Ur beamtime
- d2fd09d2 - TEMP DO NOT MERGE: add usage of spill start filter in legacy unpack macro
- c7ee62f4 - TEMP: enable TRD2D in run unpack tsa
Toggle commit list-
4b9dceb3...86ff1308 - 18 commits from branch
added 137 commits
-
c7ee62f4...8324968b - 131 commits from branch
computing:master
- 5423b4d2 - Add KickerStart (fast extr.) to SIS18 Raw AccData interface class
- 9ac2b869 - Add optional digi filter around Spill Start/Stop to legacy unpacking
- b7d0e25e - Add actual spill filtering + sanitize monitor histos generation and saving
- bc95e1cd - [mCBM 2024] add unpack params for mMUCH in June 2024 Ur beamtime
- dce6f067 - TEMP DO NOT MERGE: add usage of spill start filter in legacy unpack macro
- bead322c - TEMP: enable TRD2D in run unpack tsa
Toggle commit list-
c7ee62f4...8324968b - 131 commits from branch
added 54 commits
-
bead322c...420f38dc - 47 commits from branch
computing:master
- f84f15c6 - Add KickerStart (fast extr.) to SIS18 Raw AccData interface class
- 91302fae - Add optional digi filter around Spill Start/Stop to legacy unpacking
- 805923fc - Add actual spill filtering + sanitize monitor histos generation and saving
- 5aa2ba14 - [mCBM 2024] add unpack params for mMUCH in June 2024 Ur beamtime
- 83598f2b - TEMP DO NOT MERGE: add usage of spill start filter in legacy unpack macro
- 5edd22b9 - TEMP: enable TRD2D in run unpack tsa
- 89ba6fb6 - TEMP: change path to spill filter file to point final location on lustre
Toggle commit list-
bead322c...420f38dc - 47 commits from branch
added 41 commits
-
89ba6fb6...0ed3f9f5 - 37 commits from branch
computing:master
- 99eb4dd1 - Add KickerStart (fast extr.) to SIS18 Raw AccData interface class
- b9e16aa4 - Add optional digi filter around Spill Start/Stop to legacy unpacking
- 7ffc57cc - Add usage of spill start filter for June 2024 runs in legacy unpack macro
- 1d5e343a - Add HTD Pattern updates class to SIS18 Raw AccData interface
Toggle commit list-
89ba6fb6...0ed3f9f5 - 37 commits from branch
requested review from @p.-a.loizeau
assigned to @p.-a.loizeau
added 1 commit
- bd095b88 - Add HTD Pattern updates class to SIS18 Raw AccData interface
added 5 commits
-
96126632 - 1 commit from branch
computing:master
- aa54a40c - Add KickerStart (fast extr.) to SIS18 Raw AccData interface class
- fea3d599 - Add optional digi filter around Spill Start/Stop to legacy unpacking
- c142dfbf - Add usage of spill start filter for June 2024 runs in legacy unpack macro
- d97e0ada - Add HTD Pattern updates class to SIS18 Raw AccData interface
Toggle commit list-
96126632 - 1 commit from branch
removed review request for @p.-a.loizeau
@v.friese @f.uhlig Do you think this should be review by somebody else? If yes, whom should we ask?
This is pending since quite some time, changing mostly the legacy things and some temporary data classes which will be used only until we have a proper interface to the accelerator, and the main change is a filte applied only to a single beamtime.
As I finally found the time to cleanup and fix this, I would like to get it merged before it gets again in conflict, so that we can slowly close the mCBM campaign chapter.added 46 commits
-
d97e0ada...0a87288c - 42 commits from branch
computing:master
- 9ec091e9 - Add KickerStart (fast extr.) to SIS18 Raw AccData interface class
- 42b4d90d - Add optional digi filter around Spill Start/Stop to legacy unpacking
- d46d028b - Add usage of spill start filter for June 2024 runs in legacy unpack macro
- 31516a34 - Add HTD Pattern updates class to SIS18 Raw AccData interface
Toggle commit list-
d97e0ada...0a87288c - 42 commits from branch
added 17 commits
-
31516a34...bd8f97bb - 13 commits from branch
computing:master
- 881eb633 - Add KickerStart (fast extr.) to SIS18 Raw AccData interface class
- 4ed16ee9 - Add optional digi filter around Spill Start/Stop to legacy unpacking
- 3bb069d7 - Add usage of spill start filter for June 2024 runs in legacy unpack macro
- 681a7fee - Add HTD Pattern updates class to SIS18 Raw AccData interface
Toggle commit list-
31516a34...bd8f97bb - 13 commits from branch
added 81 commits
-
681a7fee...6224b9f7 - 77 commits from branch
computing:master
- 97a1b745 - Add KickerStart (fast extr.) to SIS18 Raw AccData interface class
- 2ad6ed66 - Add optional digi filter around Spill Start/Stop to legacy unpacking
- 3db58d3d - Add usage of spill start filter for June 2024 runs in legacy unpack macro
- 7aa9ec86 - Add HTD Pattern updates class to SIS18 Raw AccData interface
Toggle commit list-
681a7fee...6224b9f7 - 77 commits from branch
@v.friese @f.uhlig Now that the release is hopefully out of the way, could we get this merged?
In case it is a problem that we cannot find somebody to review this, I have no problem closing the MR as I do not want to loose more time rebasing/maintaining the branch, it being more than 1 year old and seemingly not strongly requested by detector groups.
But in this case the corresponding mCBM data should be clearly labelled asunusable/unreadable
onlustre
, e.g. by adding a text file in the corresponding folders-
/lustre/cbm/prod/beamtime/2024/06/mcbm/
for the TSA files which need the "spill start only filter" due to the broken SIS18 HW -
/lustre/cbm/prod/beamtime/2025/0[3-5]/mcbm/
for the accelerator Pattern events files (acc_pattern_events_*
) taken this year
-