Rich: Ring track match index fix for timebased data

Quick summary:

• Fix of out-of-bounds access/writing of std::vector, because of usage of TClonesArray container index instead of running/event index
• TClonesArray container index of RichRing now assigned to GlobalTrack, instead of running/event index
• TClonesArray container index of StsTrack now assigned to GlobalTrack, instead of running/event index

Index of the ring in the ring array was used instead of the running index -> resulted in out-of-bounds access/writing of std::vector.
(Can only be noticed for Time-Based simulations)

In case of no immediate crash, this might have even overwritten other memory locations of the programm, resulting in corrupt data.
(Maybe resulting in crashes for MatchRecoToMc?)

Maybe related to #3347, #2731

Of interest for @f.kornas

changed milestone to %OCT23

added BugFix Reconstruction labels

assigned to @v.friese

In case of no immediate crash, this might have even overwritten other memory locations of the programm, resulting in corrupt data. (Maybe resulting in crashes for MatchRecoToMc?)

I think my guess is correct. Now for reconstruction on timebased data (1 Mc input) 100 event in 1 timeslice with 100 jobs, I observe not a single crash. Not even any out-of-bounds errors in MatchRecoToMc.

@f.kornas can you confirm this?

changed title from Rich: Ring track match index fix to Rich: Ring track match index fix for timebased data

Dear @ma.beyer,

you have been identified as code owner of at least one file which was changed with this merge request.

Please check the changes and approve them or request changes.

added CodeOwners label

added 13 commits

• adbfb8a7...fa388282 - 10 commits from branch computing:master
• 99ff981f - ring track match: fix wrong index for tb simulations
• 10da7305 - also fix ring index assigned to global track
• 99f5c5db - add author and update data

Compare with previous version

changed the description

Something is still not right. When looking at QA I observe only <10% of GlobalTrack have a ring assigned for time-based, for event-based it is >90%. Currently looking into it, please dont merge yet.

marked this merge request as draft

added 11 commits

• 99f5c5db...49233621 - 7 commits from branch computing:master
• 5a89bc37 - ring track match: fix wrong index for tb simulations
• ddead69d - also fix ring index assigned to global track
• 9547d065 - add author and update data
• 03690ed8 - also assign container index of sts track to global track

Compare with previous version

marked this merge request as ready

resolved all threads

approved this merge request

enabled an automatic merge when the pipeline for 03690ed8 succeeds