Moved STS system time offset parameter from sts::ReadoutConfig to sts::WalkMap.
Changes requested by @a.toia.
Requires updated YAML files, to be submitted separately.
Merge request reports
Activity
requested review from @p.-a.loizeau
assigned to @p.-a.loizeau
- Resolved by Dominik Smith
@a.toia @p.-a.loizeau @a.toia FYI: The time offset is stored in hex format. This might be confusing for someone reading the YAML file.
mentioned in merge request CbmSoft/cbmroot_parameter!194 (merged)
- Resolved by Dominik Smith
are you sure it's an hex? I always used it as int
- Resolved by Dominik Smith
in algo/detectors/sts/ReadoutConfig.h
i32 timeOffset;
CBM_YAML_PROPERTIES(yaml::Property(&ReadoutSetup::timeOffset, "timeOffset", "Time offset for STS", YAML::Hex),
Edited by Alberica Toia
added 5 commits
-
bb43464a...823c0976 - 4 commits from branch
computing:master
- 034a0d33 - Moved STS system time offset parameter from sts::ReadoutConfig to sts::WalkMap.
-
bb43464a...823c0976 - 4 commits from branch
added Online label
- Resolved by Dominik Smith
@d.smith Did you check with a file that the changes are transparent?
I would expect then to have 1:1 digis in the output, is this assumption right?
When I tried it locally on the mFLES node with the first spill of run3105
, the files generated by themaster
version and by your two MRs combined did not have identical entries, at least according to the tool made by Florian. I will try to have a look at the Digis themselves one by one tomorrow morning.
- Resolved by Dominik Smith
@p.-a.loizeau So nothing more is to be done in this MR? The problem is in the parameter file?
- Resolved by Pierre-Alain Loizeau
@d.smith CbmSoft/cbmroot_parameter!194 (merged) is now merged, you can rebase and add the commit with the parameters repo hash update
added 39 commits
-
034a0d33...fa388282 - 37 commits from branch
computing:master
- e8c28004 - Moved STS system time offset parameter from sts::ReadoutConfig to sts::WalkMap.
- 3780c675 - Updated parameter hash.
-
034a0d33...fa388282 - 37 commits from branch
enabled an automatic merge when the pipeline for 3780c675 succeeds
added CodeOwners label