Skip to content
Snippets Groups Projects

Added YAML-configurable system offset TRD unpacker in cbm::algo.

Merged Dominik Smith requested to merge d.smith/cbmroot:TrdTimeOffset into master
All threads resolved!

Requires changes to the YAML files, which will be submitted independently.

Although these changes are minor, please test whether they achieve the desired result.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dominik Smith added 1 commit

    added 1 commit

    • 1b49851f - Added YAML-configurable system offset TRD unpacker in cbm::algo.

    Compare with previous version

  • Dominik Smith resolved all threads

    resolved all threads

  • added Online label

  • @a.bercuci @p.kaehler Could you please ping the right person in the TRD1D team to test this change?
    (This needs also to apply by hand the changes from CbmSoft/cbmroot_parameter!192 (merged))

    Unfortunately as I am waiting for the review to merge the parameter side, this one cannot pass the CI chain so the CodeOwners is not called yet :sweat_smile:

  • Pierre-Alain Loizeau mentioned in merge request !1851 (merged)

    mentioned in merge request !1851 (merged)

  • Alexandru Bercuci approved this merge request

    approved this merge request

  • Will rebase, add hash bump, check locally and set to auto-merge as soon as !1851 (merged) is merged

  • added 70 commits

    • 1b49851f...94fb376c - 68 commits from branch computing:master
    • 4af9e3c5 - Added YAML-configurable system offset TRD unpacker in cbm::algo.
    • 6a79da4e - Bump parameters repo hash to bring matching online TRD1D pars

    Compare with previous version

  • Pierre-Alain Loizeau enabled an automatic merge when the pipeline for 6a79da4e succeeds

    enabled an automatic merge when the pipeline for 6a79da4e succeeds

  • Dear @a.bercuci, @p.kaehler, @f.uhlig,

    you have been identified as code owner of at least one file which was changed with this merge request.

    Please check the changes and approve them or request changes.

  • Please register or sign in to reply
    Loading